From: Andrew Morton <akpm@linux-foundation.org>
To: Max Krasnyansky <maxk@qualcomm.com>
Cc: torvalds@linux-foundation.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] CPU isolation extensions
Date: Thu, 7 Feb 2008 11:26:52 -0800 [thread overview]
Message-ID: <20080207112652.07296f48.akpm@linux-foundation.org> (raw)
In-Reply-To: <47AB3E5A.4060107@qualcomm.com>
On Thu, 07 Feb 2008 09:22:34 -0800 Max Krasnyansky <maxk@qualcomm.com> wrote:
> > - There are two separate and identical implementations of
> > cpu_unusable(cpu). Please do it once, in a header, preferably with C
> > function, not macros.
>
> Those are local versions that depend whether a feature is enabled or not.
> If CONFIG_CPUISOL_WORKQUEUE is disabled we want to cpu_unusable()
> in the workqueue.c to be a noop, and if it's enabled that macro resolve to
> cpu_isolated().
> Same thing for the stopmachine.c. If CONFIG_CPUISOL_STOPMACHIN is disabled
> cpu_unusable() is a noop.
> In other words cpu_isolated() is the one common macro that subsystem may
> want to stub out.
> Do you see another way of doing this ?
ah, I missed that. Yup, the implementation you have there looks OK.
next prev parent reply other threads:[~2008-02-07 19:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 5:32 [git pull] CPU isolation extensions Max Krasnyansky
2008-02-07 5:58 ` Andrew Morton
2008-02-07 7:59 ` Paul Jackson
2008-02-07 8:12 ` Andrew Morton
2008-02-07 18:14 ` Max Krasnyansky
2008-02-07 18:02 ` Max Krasnyansky
2008-02-07 18:10 ` Paul Jackson
2008-02-07 18:22 ` Max Krasnyansky
2008-02-07 17:22 ` Max Krasnyansky
2008-02-07 19:26 ` Andrew Morton [this message]
2008-02-07 17:06 ` Linus Torvalds
2008-02-07 17:36 ` Max Krasnyansky
2008-02-07 19:51 ` Ingo Molnar
2008-02-08 0:38 ` Max Krasnyansky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207112652.07296f48.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.