From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dan Magenheimer" Subject: RE: [PATCH] new hvm platform vhpet enable parameter Date: Thu, 7 Feb 2008 13:53:45 -0700 Message-ID: <20080207135345296.00000003652@djm-pc> References: Reply-To: "dan.magenheimer@oracle.com" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=-------63ba7acd63ba7acd Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format ---------63ba7acd63ba7acd Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable > Yes, tools/firmware/hvmloader/acpi/dsdt.asl. The right way to = > do this will > be to gate it on a flag set up in memory by hvmloader (we = > already do this > e.g., for com1 and com2 -- see construct_bios_info_table() in = > build.c in the > same directory). That might be a bit tricky as it probably = > needs a bit of > ASL hacking, which has a little learning curve. I can take a = > look maybe next > week. OK, here's the updated patch: 1) hpet instead of vhpet 2) against 3.2-testing tip This will work without the acpi changes so could be checked in independently. Though it may be a bit misleading for the guest to print out that it found an hpet in acpi and then be unable to use it, the acpi part is largely cosmetic and (as you point out) a bit tricky so better left for your capable hands. Thanks, Dan ---------63ba7acd63ba7acd Content-Type: application/octet-stream; name="hpet.patch" Content-Disposition: attachment; filename="hpet.patch" Content-Transfer-Encoding: base64 ZGlmZiAtciBkMjZiMWI3NzdmZGUgdG9vbHMvcHl0aG9uL3hlbi94ZW5kL1hlbmRDb25maWcu cHkKLS0tIGEvdG9vbHMvcHl0aG9uL3hlbi94ZW5kL1hlbmRDb25maWcucHkJV2VkIEZlYiAw NiAxMDowNjozNSAyMDA4ICswMDAwCisrKyBiL3Rvb2xzL3B5dGhvbi94ZW4veGVuZC9YZW5k Q29uZmlnLnB5CVRodSBGZWIgMDcgMTM6MzI6MjYgMjAwOCAtMDcwMApAQCAtMTI3LDcgKzEy Nyw3IEBAIFhFTkFQSV9QTEFURk9STV9DRkcgPSBbICdhY3BpJywgJ2FwaWMnLCAKIFhFTkFQ SV9QTEFURk9STV9DRkcgPSBbICdhY3BpJywgJ2FwaWMnLCAnYm9vdCcsICdkZXZpY2VfbW9k ZWwnLCAnZGlzcGxheScsIAogICAgICAgICAgICAgICAgICAgICAgICAgJ2ZkYScsICdmZGIn LCAna2V5bWFwJywgJ2lzYScsICdsb2NhbHRpbWUnLCAnbW9uaXRvcicsIAogICAgICAgICAg ICAgICAgICAgICAgICAgJ25vZ3JhcGhpYycsICdwYWUnLCAncnRjX3RpbWVvZmZzZXQnLCAn c2VyaWFsJywgJ3NkbCcsCi0gICAgICAgICAgICAgICAgICAgICAgICAnc291bmRodycsJ3N0 ZHZnYScsICd1c2InLCAndXNiZGV2aWNlJywgJ3ZuYycsCisgICAgICAgICAgICAgICAgICAg ICAgICAnc291bmRodycsJ3N0ZHZnYScsICd1c2InLCAndXNiZGV2aWNlJywgJ2hwZXQnLCAn dm5jJywKICAgICAgICAgICAgICAgICAgICAgICAgICd2bmNjb25zb2xlJywgJ3ZuY2Rpc3Bs YXknLCAndm5jbGlzdGVuJywgJ3RpbWVyX21vZGUnLAogICAgICAgICAgICAgICAgICAgICAg ICAgJ3ZuY3Bhc3N3ZCcsICd2bmN1bnVzZWQnLCAneGF1dGhvcml0eScsICdwY2knLCAndmhw dCcsCiAgICAgICAgICAgICAgICAgICAgICAgICAnZ3Vlc3Rfb3NfdHlwZScgXQpkaWZmIC1y IGQyNmIxYjc3N2ZkZSB0b29scy9weXRob24veGVuL3hlbmQvWGVuZENvbnN0YW50cy5weQot LS0gYS90b29scy9weXRob24veGVuL3hlbmQvWGVuZENvbnN0YW50cy5weQlXZWQgRmViIDA2 IDEwOjA2OjM1IDIwMDggKzAwMDAKKysrIGIvdG9vbHMvcHl0aG9uL3hlbi94ZW5kL1hlbmRD b25zdGFudHMucHkJVGh1IEZlYiAwNyAxMzozMjoyNiAyMDA4IC0wNzAwCkBAIC00Nyw2ICs0 Nyw3IEBAIEhWTV9QQVJBTV9WSFBUX1NJWkUgICAgPSA4CiBIVk1fUEFSQU1fVkhQVF9TSVpF ICAgID0gOAogSFZNX1BBUkFNX0JVRlBJT1JFUV9QRk4gPSA5CiBIVk1fUEFSQU1fVElNRVJf TU9ERSAgID0gMTAKK0hWTV9QQVJBTV9IUEVUICAgICAgICAgPSAxMQogCiByZXN0YXJ0X21v ZGVzID0gWwogICAgICJyZXN0YXJ0IiwKZGlmZiAtciBkMjZiMWI3NzdmZGUgdG9vbHMvcHl0 aG9uL3hlbi94ZW5kL1hlbmREb21haW5JbmZvLnB5Ci0tLSBhL3Rvb2xzL3B5dGhvbi94ZW4v eGVuZC9YZW5kRG9tYWluSW5mby5weQlXZWQgRmViIDA2IDEwOjA2OjM1IDIwMDggKzAwMDAK KysrIGIvdG9vbHMvcHl0aG9uL3hlbi94ZW5kL1hlbmREb21haW5JbmZvLnB5CVRodSBGZWIg MDcgMTM6MzI6MjYgMjAwOCAtMDcwMApAQCAtMTY1OSw2ICsxNjU5LDEyIEBAIGNsYXNzIFhl bmREb21haW5JbmZvOgogICAgICAgICBpZiBodm0gYW5kIHRpbWVyX21vZGUgaXMgbm90IE5v bmU6CiAgICAgICAgICAgICB4Yy5odm1fc2V0X3BhcmFtKHNlbGYuZG9taWQsIEhWTV9QQVJB TV9USU1FUl9NT0RFLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb25nKHRpbWVy X21vZGUpKQorCisgICAgICAgICMgT3B0aW9uYWxseSBlbmFibGUgdmlydHVhbCBIUEVUCisg ICAgICAgIGhwZXQgPSBzZWxmLmluZm9bInBsYXRmb3JtIl0uZ2V0KCJocGV0IikKKyAgICAg ICAgaWYgaHZtIGFuZCBocGV0IGlzIG5vdCBOb25lOgorICAgICAgICAgICAgeGMuaHZtX3Nl dF9wYXJhbShzZWxmLmRvbWlkLCBIVk1fUEFSQU1fSFBFVCwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbG9uZyhocGV0KSkKIAogICAgICAgICAjIFNldCBtYXhpbXVtIG51bWJl ciBvZiB2Y3B1cyBpbiBkb21haW4KICAgICAgICAgeGMuZG9tYWluX21heF92Y3B1cyhzZWxm LmRvbWlkLCBpbnQoc2VsZi5pbmZvWydWQ1BVc19tYXgnXSkpCmRpZmYgLXIgZDI2YjFiNzc3 ZmRlIHRvb2xzL3B5dGhvbi94ZW4veG0vY3JlYXRlLnB5Ci0tLSBhL3Rvb2xzL3B5dGhvbi94 ZW4veG0vY3JlYXRlLnB5CVdlZCBGZWIgMDYgMTA6MDY6MzUgMjAwOCArMDAwMAorKysgYi90 b29scy9weXRob24veGVuL3htL2NyZWF0ZS5weQlUaHUgRmViIDA3IDEzOjMyOjI2IDIwMDgg LTA3MDAKQEAgLTE5Myw2ICsxOTMsMTAgQEAgZ29wdHMudmFyKCdwYWUnLCB2YWw9J1BBRScs CiBnb3B0cy52YXIoJ3BhZScsIHZhbD0nUEFFJywKICAgICAgICAgICBmbj1zZXRfaW50LCBk ZWZhdWx0PTEsCiAgICAgICAgICAgdXNlPSJEaXNhYmxlIG9yIGVuYWJsZSBQQUUgb2YgSFZN IGRvbWFpbi4iKQorCitnb3B0cy52YXIoJ2hwZXQnLCB2YWw9J0hQRVQnLAorICAgICAgICAg IGZuPXNldF9pbnQsIGRlZmF1bHQ9MCwKKyAgICAgICAgICB1c2U9IkVuYWJsZSB2aXJ0dWFs IGhpZ2gtcHJlY2lzaW9uIGV2ZW50IHRpbWVyLiIpCiAKIGdvcHRzLnZhcigndGltZXJfbW9k ZScsIHZhbD0nVElNRVJfTU9ERScsCiAgICAgICAgICAgZm49c2V0X2ludCwgZGVmYXVsdD0w LApAQCAtNzIzLDcgKzcyNyw3IEBAIGRlZiBjb25maWd1cmVfaHZtKGNvbmZpZ19pbWFnZSwg dmFscyk6CiAgICAgICAgICAgICAgJ2xvY2FsdGltZScsICdzZXJpYWwnLCAnc3RkdmdhJywg J2lzYScsICdub2dyYXBoaWMnLCAnc291bmRodycsCiAgICAgICAgICAgICAgJ3ZuYycsICd2 bmNkaXNwbGF5JywgJ3ZuY3VudXNlZCcsICd2bmNjb25zb2xlJywgJ3ZuY2xpc3RlbicsCiAg ICAgICAgICAgICAgJ3NkbCcsICdkaXNwbGF5JywgJ3hhdXRob3JpdHknLCAncnRjX3RpbWVv ZmZzZXQnLCAnbW9uaXRvcicsCi0gICAgICAgICAgICAgJ2FjcGknLCAnYXBpYycsICd1c2In LCAndXNiZGV2aWNlJywgJ2tleW1hcCcsICdwY2knLAorICAgICAgICAgICAgICdhY3BpJywg J2FwaWMnLCAndXNiJywgJ3VzYmRldmljZScsICdrZXltYXAnLCAncGNpJywgJ2hwZXQnLAog ICAgICAgICAgICAgICdndWVzdF9vc190eXBlJ10KIAogICAgIGZvciBhIGluIGFyZ3M6CmRp ZmYgLXIgZDI2YjFiNzc3ZmRlIHRvb2xzL3B5dGhvbi94ZW4veG0veGVuYXBpX2NyZWF0ZS5w eQotLS0gYS90b29scy9weXRob24veGVuL3htL3hlbmFwaV9jcmVhdGUucHkJV2VkIEZlYiAw NiAxMDowNjozNSAyMDA4ICswMDAwCisrKyBiL3Rvb2xzL3B5dGhvbi94ZW4veG0veGVuYXBp X2NyZWF0ZS5weQlUaHUgRmViIDA3IDEzOjMyOjI2IDIwMDggLTA3MDAKQEAgLTgxOCw3ICs4 MTgsNyBAQCBjbGFzcyBzeHAyeG1sOgogCiAKICAgICBkZWYgZXh0cmFjdF9wbGF0Zm9ybShz ZWxmLCBpbWFnZSwgZG9jdW1lbnQpOgotICAgICAgICBwbGF0Zm9ybV9rZXlzID0gWydhY3Bp JywgJ2FwaWMnLCAncGFlJywgJ3ZocHQnLCAndGltZXJfbW9kZSddCisgICAgICAgIHBsYXRm b3JtX2tleXMgPSBbJ2FjcGknLCAnYXBpYycsICdwYWUnLCAndmhwdCcsICd0aW1lcl9tb2Rl JywgJ2hwZXQnXQogCiAgICAgICAgIGRlZiBleHRyYWN0X3BsYXRmb3JtX2tleShrZXkpOgog ICAgICAgICAgICAgcGxhdGZvcm0gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJwbGF0Zm9y bSIpCmRpZmYgLXIgZDI2YjFiNzc3ZmRlIHhlbi9hcmNoL3g4Ni9odm0vaHBldC5jCi0tLSBh L3hlbi9hcmNoL3g4Ni9odm0vaHBldC5jCVdlZCBGZWIgMDYgMTA6MDY6MzUgMjAwOCArMDAw MAorKysgYi94ZW4vYXJjaC94ODYvaHZtL2hwZXQuYwlUaHUgRmViIDA3IDEzOjMyOjI2IDIw MDggLTA3MDAKQEAgLTM1Myw2ICszNTMsOCBAQCBzdGF0aWMgdm9pZCBocGV0X3dyaXRlKAog CiBzdGF0aWMgaW50IGhwZXRfcmFuZ2Uoc3RydWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcg YWRkcikKIHsKKyAgICBpZiAoISh2LT5kb21haW4tPmFyY2guaHZtX2RvbWFpbi5wYXJhbXNb SFZNX1BBUkFNX0hQRVRdKSkKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgcmV0dXJuICgoYWRk ciA+PSBIUEVUX0JBU0VfQUREUkVTUykgJiYKICAgICAgICAgICAgIChhZGRyIDwgKEhQRVRf QkFTRV9BRERSRVNTICsgSFBFVF9NTUFQX1NJWkUpKSk7CiB9CmRpZmYgLXIgZDI2YjFiNzc3 ZmRlIHhlbi9pbmNsdWRlL3B1YmxpYy9odm0vcGFyYW1zLmgKLS0tIGEveGVuL2luY2x1ZGUv cHVibGljL2h2bS9wYXJhbXMuaAlXZWQgRmViIDA2IDEwOjA2OjM1IDIwMDggKzAwMDAKKysr IGIveGVuL2luY2x1ZGUvcHVibGljL2h2bS9wYXJhbXMuaAlUaHUgRmViIDA3IDEzOjMyOjI2 IDIwMDggLTA3MDAKQEAgLTgxLDYgKzgxLDEyIEBACiAjZGVmaW5lIEhWTVBUTV9ub19taXNz ZWRfdGlja3NfcGVuZGluZyAgIDIKICNkZWZpbmUgSFZNUFRNX29uZV9taXNzZWRfdGlja19w ZW5kaW5nICAgMwogCi0jZGVmaW5lIEhWTV9OUl9QQVJBTVMgICAgICAgICAgMTEKKy8qCisg KiBFbmFibGUgdmlydHVhbCBIUEVUIChoaWdoLXByZWNpc2lvbiBldmVudCB0aW1lcikgKHg4 Ni1vbmx5KQorICogIDA9ZGlzYWJsZWQsIDEtZW5hYmxlZAorICovCisjZGVmaW5lIEhWTV9Q QVJBTV9IUEVUIDExCisKKyNkZWZpbmUgSFZNX05SX1BBUkFNUyAgICAgICAgICAxMgogCiAj ZW5kaWYgLyogX19YRU5fUFVCTElDX0hWTV9QQVJBTVNfSF9fICovCg== ---------63ba7acd63ba7acd Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel ---------63ba7acd63ba7acd--