From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH] ioemu: make daemonize optional Date: Thu, 7 Feb 2008 14:37:54 +0000 Message-ID: <20080207143754.GE30230@redhat.com> References: <20080207142251.GF9343@implementation.uk.xensource.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20080207142251.GF9343@implementation.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Samuel Thibault , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, Feb 07, 2008 at 02:22:51PM +0000, Samuel Thibault wrote: > ioemu: make daemonize optional Why ? Littering up the source code with lots of #ifdef isn't very nice for maintainance. Can we at least have some explanation of the actual need for these changes along with the patch. NB, I'm not against the patch - when looking through changelogs it just helps to have good description of the reasoning behind the change, and in this case 'make daemonize optional' doesn't tell me anything over and above what the diff itself shows. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|