From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-ide@vger.kernel.org,
Anton Salnikov <asalnikov@ru.mvista.com>,
Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: [PATCH 2.5/3] palm_bk3710: port initialization/probing bugfix
Date: Thu, 7 Feb 2008 21:50:34 +0100 [thread overview]
Message-ID: <200802072150.34389.bzolnier@gmail.com> (raw)
Probe port _after_ it is fully initialized.
Cc: Anton Salnikov <asalnikov@ru.mvista.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/arm/palm_bk3710.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
Index: b/drivers/ide/arm/palm_bk3710.c
===================================================================
--- a/drivers/ide/arm/palm_bk3710.c
+++ b/drivers/ide/arm/palm_bk3710.c
@@ -370,13 +370,6 @@ static int __devinit palm_bk3710_probe(s
ide_init_port_hw(hwif, &hw);
hwif->quirkproc = NULL;
- idx[0] = i;
-
- ide_device_add(idx, NULL);
-
- if (!hwif->present)
- goto out;
-
hwif->set_pio_mode = &palm_bk3710_set_pio_mode;
hwif->set_dma_mode = &palm_bk3710_set_dma_mode;
hwif->mmio = 1;
@@ -390,6 +383,13 @@ static int __devinit palm_bk3710_probe(s
ide_setup_dma(hwif, mem->start);
+ idx[0] = i;
+
+ ide_device_add(idx, NULL);
+
+ if (!hwif->present)
+ goto out;
+
return 0;
out:
printk(KERN_WARNING "Palm Chip BK3710 IDE Register Fail\n");
next reply other threads:[~2008-02-07 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 20:50 Bartlomiej Zolnierkiewicz [this message]
2008-02-08 17:32 ` [PATCH 2.5/3] palm_bk3710: port initialization/probing bugfix Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802072150.34389.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=asalnikov@ru.mvista.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.