From: Andi Kleen <ak@suse.de>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"Brown, Len" <len.brown@intel.com>,
Adam Belay <abelay@novell.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86: Simplify cpu_idle_wait
Date: Fri, 8 Feb 2008 11:28:48 +0100 [thread overview]
Message-ID: <200802081128.48621.ak@suse.de> (raw)
In-Reply-To: <20080208010550.GA8090@linux-os.sc.intel.com>
> - set_cpus_allowed(current, tmp);
> + smp_mb();
> + /* kick all the CPUs so that they exit out of pm_idle */
> + smp_call_function(do_nothing, NULL, 0, 0);
I think the last argument (wait) needs to be 1 to make sure it is
synchronous (for 32/64) Otherwise the patch looks great.
-Andi
next prev parent reply other threads:[~2008-02-08 10:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 2:27 [RFC PATCH] kick sleeping idle CPUS on cpu_idle_wait Steven Rostedt
2008-01-08 3:33 ` Andi Kleen
2008-01-09 20:42 ` [PATCH] Kick CPUS that might be sleeping in cpus_idle_wait Steven Rostedt
2008-01-09 22:12 ` Steven Rostedt
2008-01-10 13:45 ` Ingo Molnar
2008-01-10 14:43 ` Steven Rostedt
2008-01-10 17:31 ` Pallipadi, Venkatesh
2008-01-10 18:03 ` Steven Rostedt
2008-01-09 23:42 ` Andrew Morton
2008-01-10 0:05 ` Steven Rostedt
2008-01-10 0:12 ` Pallipadi, Venkatesh
[not found] ` <B5B0CFF685D7DF46A05CF1678CFB42ED20E00653@orsmsx423.amr.corp.intel.com>
2008-02-08 1:05 ` [PATCH] x86: Simplify cpu_idle_wait Venki Pallipadi
2008-02-08 10:28 ` Andi Kleen [this message]
2008-02-08 17:24 ` Venki Pallipadi
2008-02-08 18:45 ` Andi Kleen
2008-02-09 9:33 ` Thomas Gleixner
2008-04-10 16:49 ` Venki Pallipadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802081128.48621.ak@suse.de \
--to=ak@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=abelay@novell.com \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.