Re: [PATCH 1/3] hugetlb: numafy several functions

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 08.02.2008 [10:37:24 -0600], Adam Litke wrote:
> On Wed, 2008-02-06 at 15:15 -0800, Nishanth Aravamudan wrote:
> > @@ -141,6 +149,18 @@ static void free_huge_page(struct page *page)
> >   * balanced by operating on them in a round-robin fashion.
> >   * Returns 1 if an adjustment was made.
> >   */
> > +static int adjust_pool_surplus_node(int delta, int nid)
> > +{
> > +	if (delta < 0 && !surplus_huge_pages_node[nid])
> > +		return 0;
> > +	if (delta > 0 && surplus_huge_pages_node[nid] >=
> > +					nr_huge_pages_node[nid])
> > +		return 0;
> > +	surplus_huge_pages += delta;
> > +	surplus_huge_pages_node[nid] += delta;
> > +	return 1;
> > +}
> > +
> >  static int adjust_pool_surplus(int delta)
> >  {
> >  	static int prev_nid;
> > @@ -152,19 +172,9 @@ static int adjust_pool_surplus(int delta)
> >  		nid = next_node(nid, node_online_map);
> >  		if (nid == MAX_NUMNODES)
> >  			nid = first_node(node_online_map);
> > -
> > -		/* To shrink on this node, there must be a surplus page */
> > -		if (delta < 0 && !surplus_huge_pages_node[nid])
> > -			continue;
> > -		/* Surplus cannot exceed the total number of pages */
> > -		if (delta > 0 && surplus_huge_pages_node[nid] >=
> > -						nr_huge_pages_node[nid])
> > -			continue;
> 
> Unless I am misreading the diff, it seems the above comments were lost
> in translation.  I vote for preserving them :)  Otherwise this looks
> pretty good to me.

Oops, sorry about that, Adam. I'll update this in my next posting,
pending any other comments/testing feedback.

Thanks,
Nish

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>