* - proc-detect-duplicate-names-on-registration.patch removed from -mm tree
@ 2008-02-08 20:11 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2008-02-08 20:11 UTC (permalink / raw)
To: rui.zhang, adobriyan, mm-commits
The patch titled
proc: detect duplicate names on registration
has been removed from the -mm tree. Its filename was
proc-detect-duplicate-names-on-registration.patch
This patch was dropped because it was merged into mainline or a subsystem tree
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: proc: detect duplicate names on registration
From: Zhang Rui <rui.zhang@intel.com>
Print a warning if PDE is registered with a name which already exists in
target directory.
Bug report and a simple fix can be found here:
http://bugzilla.kernel.org/show_bug.cgi?id=8798
[\n fixlet and no undescriptive variable usage --adobriyan]
[akpm@linux-foundation.org: make printk comprehensible]
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/proc/generic.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff -puN fs/proc/generic.c~proc-detect-duplicate-names-on-registration fs/proc/generic.c
--- a/fs/proc/generic.c~proc-detect-duplicate-names-on-registration
+++ a/fs/proc/generic.c
@@ -521,6 +521,7 @@ static const struct inode_operations pro
static int proc_register(struct proc_dir_entry * dir, struct proc_dir_entry * dp)
{
unsigned int i;
+ struct proc_dir_entry *tmp;
i = get_inode_number();
if (i == 0)
@@ -544,6 +545,15 @@ static int proc_register(struct proc_dir
}
spin_lock(&proc_subdir_lock);
+
+ for (tmp = dir->subdir; tmp; tmp = tmp->next)
+ if (strcmp(tmp->name, dp->name) == 0) {
+ printk(KERN_WARNING "proc_dir_entry '%s' already "
+ "registered\n", dp->name);
+ dump_stack();
+ break;
+ }
+
dp->next = dir->subdir;
dp->parent = dir;
dir->subdir = dp;
_
Patches currently in -mm which might be from rui.zhang@intel.com are
origin.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-02-08 20:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-08 20:11 - proc-detect-duplicate-names-on-registration.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.