From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JNbup-000155-Ja for mharc-grub-devel@gnu.org; Fri, 08 Feb 2008 17:41:51 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JNbun-00012Y-EK for grub-devel@gnu.org; Fri, 08 Feb 2008 17:41:49 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JNbul-0000zw-Mi for grub-devel@gnu.org; Fri, 08 Feb 2008 17:41:48 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JNbul-0000zm-G4 for grub-devel@gnu.org; Fri, 08 Feb 2008 17:41:47 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JNbul-0004Vy-93 for grub-devel@gnu.org; Fri, 08 Feb 2008 17:41:47 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JNbui-0007nS-23 for grub-devel@gnu.org; Fri, 08 Feb 2008 23:41:46 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JNbsr-0004Ek-JF for grub-devel@gnu.org; Fri, 08 Feb 2008 23:39:49 +0100 Date: Fri, 8 Feb 2008 23:39:49 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080208223949.GA12839@thorin> References: <20080206211840.GA13360@thorin> <20080206231401.GA17655@thorin> <20080208145236.GA19517@thorin> <1202498431.5332.3.camel@xerces> <20080208193856.GD24599@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix for partmap detection on RAID/LVM X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Feb 2008 22:41:49 -0000 On Fri, Feb 08, 2008 at 09:38:25PM +0000, Sam Morris wrote: > > diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp -N > > ../grub2/disk/raid.c ./disk/raid.c --- ../grub2/disk/raid.c > > 2008-02-08 13:35:05.000000000 +0100 +++ ./disk/raid.c 2008-02-08 > > 20:36:47.000000000 +0100 @@ -419,7 +419,7 @@ grub_raid_scan_device > > (const char *name) > > return 0; > > } > > > > - if (array->device[sb.this_disk.number]->name != 0) + if > > (array->device[sb.this_disk.number] != NULL) > > { > > /* We found multiple devices with the same number. Again, > > this shouldn't happen.*/ > > > > does this work? > > Looks like it! Great. I have committed the segfault bugfix (but not the partmap patch yet). > $ sudo ./grub-probe -t partmap /boot/grub/ > pc > pc Now that I think about it... does this cause grub-install / grub-mkimage to load pc.mod twice? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)