From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JNouJ-0002EV-Jb for mharc-grub-devel@gnu.org; Sat, 09 Feb 2008 07:34:11 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JNouH-0002EN-S3 for grub-devel@gnu.org; Sat, 09 Feb 2008 07:34:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JNouF-0002EB-G3 for grub-devel@gnu.org; Sat, 09 Feb 2008 07:34:08 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JNouF-0002E8-9s for grub-devel@gnu.org; Sat, 09 Feb 2008 07:34:07 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JNouF-0002QM-8q for grub-devel@gnu.org; Sat, 09 Feb 2008 07:34:07 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JNouD-0000cH-OL for grub-devel@gnu.org; Sat, 09 Feb 2008 13:34:06 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JNosg-0000gb-CT for grub-devel@gnu.org; Sat, 09 Feb 2008 13:32:30 +0100 Date: Sat, 9 Feb 2008 13:32:30 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080209123230.GB970@thorin> References: <47ACA35C.6080803@t-online.de> <20080208191743.GB24599@thorin> <47ACD19B.8040702@t-online.de> <20080208224510.GB12839@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Create floppy emulation boot CD with grub-mkimage X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Feb 2008 12:34:10 -0000 On Sat, Feb 09, 2008 at 07:56:16PM +0800, Bean wrote: > if (grub_root_drive == 0xFF) > grub_root_drive = grub_boot_drive; > > - if (grub_root_drive >= GRUB_BIOSDISK_MACHINE_CDROM_START) > - grub_sprintf (dev, "(cd%u", > - grub_root_drive - GRUB_BIOSDISK_MACHINE_CDROM_START); > + if ((grub_root_drive >= GRUB_BIOSDISK_MACHINE_CDROM_START) && > + (grub_root_drive < GRUB_BIOSDISK_MACHINE_CDROM_END)) > + grub_strcpy (dev, "(cd0)"); > else > grub_sprintf (dev, "(%cd%u", > (grub_root_drive & 0x80) ? 'h' : 'f', I'm confused by this. Did you mean the opposite? I.e. when grub_root_drive is out of bounds, set dev to cd0. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)