All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
	"Daniel Barkalow" <barkalow@iabervon.org>,
	git@vger.kernel.org
Subject: Re: [RFC] New commit object headers: note headers
Date: Sun, 10 Feb 2008 00:26:38 +0100	[thread overview]
Message-ID: <200802100026.39340.jnareb@gmail.com> (raw)
In-Reply-To: <7vlk5tetaa.fsf@gitster.siamese.dyndns.org>

On Sat, 9 Feb 2008, Junio C Hamano wrote:
> "Nguyen Thai Ngoc Duy" <pclouds@gmail.com> writes:
>> On Sun, Feb 10, 2008 at 12:35 AM, Daniel Barkalow <barkalow@iabervon.org> wrote:
>>> On Sat, 9 Feb 2008, Jakub Narebski wrote:
>>>>
>>>> 2. 'note' header (no semantical meaning)
>>>>
>>>> There was some time ago discussion about adding 'note' header, initially
>>>> to save original sha-1 of a commit for cherry-picking and rebase; then
>>>> for saving explicit rename or corrected rename info, for saving chosen
>>>> merge strategy, and for saving original ID of SCM import.
>>>
>>>  Probably want to have a prescribed syntax for specifying what note this
>>>  is, so that different programs using notes don't confuse each other.
>>
>> How about git ignoring all X- headers and let programs freely add
>> them? For example, X-SVN may be used for git-svn.
> 
> Please don't.
> 
> When two people/programs create an otherwise identical (for the
> purpose of git) commits that have two different object names,
> there'd better be a very good reason other than "I felt like
> adding an extra header that I can use willy-nilly".
> 
> Please separate the 'note' part and the 'generation' part and
> make two separate discussion threads.
> 
> And kill 'note' part altogether, but that can be done in that
> thread ;-).

Ah, well... very good reservation. So here it goes generic 'note'
(or 'X-*', similarly to non-standarized email headers) header...

Still I think it is would be nice to have original commit id in
a header when importing from foreign SCM. First, it would not pollute
commit message, which would be identical with the original commit
message (which allows easy two-way interaction). Second, it is
much easier and much less error prone to extract it by machine.

As to marking explicitely renames and copies...
-- 
Jakub Narebski
Poland

  reply	other threads:[~2008-02-09 23:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-09 16:46 [RFC] New commit object headers: generation and note headers Jakub Narebski
2008-02-09 17:35 ` Daniel Barkalow
2008-02-09 17:50   ` Nguyen Thai Ngoc Duy
2008-02-09 21:03     ` Junio C Hamano
2008-02-09 23:26       ` Jakub Narebski [this message]
2008-02-10  1:08         ` [RFC] New commit object headers: " Johannes Schindelin
2008-02-11 10:08           ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802100026.39340.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.