From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JOJPV-00048g-5z for mharc-grub-devel@gnu.org; Sun, 10 Feb 2008 16:08:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JOJPT-00048E-Gr for grub-devel@gnu.org; Sun, 10 Feb 2008 16:08:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JOJPS-00047u-6h for grub-devel@gnu.org; Sun, 10 Feb 2008 16:08:23 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JOJPR-00047r-UQ for grub-devel@gnu.org; Sun, 10 Feb 2008 16:08:21 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JOJPR-0007F6-Ik for grub-devel@gnu.org; Sun, 10 Feb 2008 16:08:21 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JOJPE-0003hr-CU for grub-devel@gnu.org; Sun, 10 Feb 2008 22:08:14 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JOJMw-0001TX-4d for grub-devel@gnu.org; Sun, 10 Feb 2008 22:05:46 +0100 Date: Sun, 10 Feb 2008 22:05:46 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080210210546.GE4916@thorin> References: <20071103230631.GA2875@boeglin.org> <87hcjuhzo8.fsf@xs4all.nl> <20071118181403.GA11941@boeglin.org> <20080123114331.GA27060@thorin> <20080205213929.GB21086@boeglin.org> <20080205221023.GA30724@thorin> <20080210163727.GA32575@boeglin.org> <20080210165612.GA12707@thorin> <20080210195408.GB1165@boeglin.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080210195408.GB1165@boeglin.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Generic halt and reboot commands (was: Re: grub2 efi patches) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Feb 2008 21:08:23 -0000 On Sun, Feb 10, 2008 at 08:54:08PM +0100, Alexandre Boeglin wrote: > +#ifdef GRUB_MACHINE_IEEE1275 > #include > +#elif defined GRUB_MACHINE_EFI > +#include > +#endif For consistency with similar code elsewhere in GRUB, I think it's better if you made this: #if defined(foo) #elif defined(bar) #endif -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)