From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JOKBG-0000bS-Dn
	for mharc-grub-devel@gnu.org; Sun, 10 Feb 2008 16:57:46 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JOKBE-0000Z4-EV
	for grub-devel@gnu.org; Sun, 10 Feb 2008 16:57:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JOKBA-0000U3-Pt
	for grub-devel@gnu.org; Sun, 10 Feb 2008 16:57:43 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JOKBA-0000Tl-FY
	for grub-devel@gnu.org; Sun, 10 Feb 2008 16:57:40 -0500
Received: from bigbox.boeglin.org ([88.191.20.48])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <alex@boeglin.org>) id 1JOKBA-0007pA-2f
	for grub-devel@gnu.org; Sun, 10 Feb 2008 16:57:40 -0500
Received: by bigbox.boeglin.org (Postfix, from userid 1000)
	id 4B0F994097; Sun, 10 Feb 2008 22:58:02 +0100 (CET)
Date: Sun, 10 Feb 2008 22:58:02 +0100
From: Alexandre Boeglin <alex@boeglin.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Message-ID: <20080210215802.GC1165@boeglin.org>
References: <20071103230631.GA2875@boeglin.org> <87hcjuhzo8.fsf@xs4all.nl>
	<20071118181403.GA11941@boeglin.org>
	<20080123114331.GA27060@thorin>
	<20080205213929.GB21086@boeglin.org>
	<20080205221023.GA30724@thorin>
	<20080210163727.GA32575@boeglin.org>
	<20080210165612.GA12707@thorin> <20080210195408.GB1165@boeglin.org>
	<20080210210546.GE4916@thorin>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20080210210546.GE4916@thorin>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Content-Transfer-Encoding: quoted-printable
X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2)
Subject: Re: Generic halt and reboot commands (was: Re: grub2 efi patches)
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Feb 2008 21:57:44 -0000

Le dim 10 f=E9v 2008 =E0 22:05:46 +0100, Robert Millan a =E9crit :
> For consistency with similar code elsewhere in GRUB, I think it's bette=
r if
> you made this:
>=20
> #if defined(foo)
> #elif defined(bar)
> #endif

No whitespace before the opening bracket in this case ?

By the way, this case is a good example of when it's 10 times easier to
produce a patch with SVN than with CVS ;)


Alex