From: Willy Tarreau <w@1wt.eu>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
stable@kernel.org, jens.axboe@oracle.com,
akpm@linux-foundation.org, bastian@waldi.eu.org,
ndenev@gmail.com, oliver.pntr@gmail.com
Subject: Re: [PATCH] splice: fix user pointer access in get_iovec_page_array()
Date: Mon, 11 Feb 2008 00:37:04 +0100 [thread overview]
Message-ID: <20080210233703.GR8953@1wt.eu> (raw)
In-Reply-To: <Pine.LNX.4.64.0802101644510.12440@sbz-30.cs.Helsinki.FI>
On Sun, Feb 10, 2008 at 04:47:57PM +0200, Pekka J Enberg wrote:
> From: Bastian Blank <bastian@waldi.eu.org>
>
> The commit 8811930dc74a503415b35c4a79d14fb0b408a361 ("splice: missing user
> pointer access verification") added access_ok() to copy_from_user_mmap_sem()
> which only ensures we can copy the struct iovecs from userspace to the kernel
> but we also must check whether we can access the actual memory region pointed
> to by the struct iovec to close the local root exploit.
>
> Cc: <stable@kernel.org>
> Cc: Jens Axboe <jens.axboe@oracle.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> ---
> Bastian, can I have your Signed-off-by for this, please? Oliver, Niki, can
> you please confirm this closes the hole?
Pekka, I confirm that it also closes the hole once backported to 2.6.22.
Willy
next prev parent reply other threads:[~2008-02-10 23:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 14:47 [PATCH] splice: fix user pointer access in get_iovec_page_array() Pekka J Enberg
2008-02-10 15:17 ` Bastian Blank
2008-02-10 15:31 ` Oliver Pinter
2008-02-10 23:37 ` Willy Tarreau [this message]
2008-02-11 6:24 ` Oliver Pinter
2008-02-11 7:29 ` [PATCH] vmsplice exploit fix (was: splice: fix user pointer access in get_iovec_page_array) Daniel Phillips
2008-02-11 7:49 ` Pekka Enberg
2008-02-11 8:00 ` Daniel Phillips
2008-02-11 7:53 ` [stable] " Greg KH
2008-02-11 8:05 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080210233703.GR8953@1wt.eu \
--to=w@1wt.eu \
--cc=akpm@linux-foundation.org \
--cc=bastian@waldi.eu.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndenev@gmail.com \
--cc=oliver.pntr@gmail.com \
--cc=penberg@cs.helsinki.fi \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.