From: David Miller <davem@davemloft.net>
To: chris.mason@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
btrfs-devel@oss.oracle.com
Subject: Re: [ANNOUNCE] Btrfs v0.12 released
Date: Mon, 11 Feb 2008 22:43:38 -0800 (PST) [thread overview]
Message-ID: <20080211.224338.07019204.davem@davemloft.net> (raw)
In-Reply-To: <200802110842.21312.chris.mason@oracle.com>
From: Chris Mason <chris.mason@oracle.com>
Date: Mon, 11 Feb 2008 08:42:20 -0500
> The kernel is actually worse, because the set/get macros are more complex.
> Some live in ctree.h like in the progs, but the nasty ones live in
> struct-funcs.c
This is really problematic, because you've got these things called
"btrfs_item_ptr()" which really isn't a pointer, it's a relative
'unsigned long' offset cast to a pointer. The source of this
seems to be btrfs_leaf_data().
And then those things get passed down into the SETGET functions!
Then deeper down we have terribly inconsistent things like
btrfs_item_nr_offset() and
btrfs_item_offset_nr().
Sigh... I'll see what I can do.
next prev parent reply other threads:[~2008-02-12 6:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 17:00 [ANNOUNCE] Btrfs v0.12 released Chris Mason
2008-02-11 1:12 ` David Miller
2008-02-11 13:42 ` Chris Mason
2008-02-12 6:43 ` David Miller [this message]
2008-02-12 13:43 ` Chris Mason
2008-02-12 7:21 ` BTRFS partition usage David Miller
2008-02-12 8:11 ` David Miller
2008-02-12 13:49 ` Chris Mason
2008-02-12 14:00 ` Jan Engelhardt
2008-02-12 14:08 ` Chris Mason
2008-02-12 14:21 ` Jan Engelhardt
2008-02-12 14:35 ` Chris Mason
2008-02-12 14:35 ` Chris Mason
2008-02-12 15:04 ` Jan Engelhardt
2008-02-12 16:17 ` Chris Mason
2008-02-12 23:38 ` David Miller
2008-02-12 23:42 ` Jan Engelhardt
2008-02-13 1:09 ` David Miller
2008-02-13 1:22 ` Rene Herman
2008-02-12 23:35 ` David Miller
2008-02-13 7:02 ` Christoph Hellwig
2008-02-12 23:34 ` David Miller
2008-02-12 23:33 ` David Miller
2008-02-13 2:10 ` Jeff Garzik
2008-02-14 0:51 ` Szabolcs Szakacsits
2008-02-12 23:26 ` David Miller
2008-02-12 23:39 ` Jan Engelhardt
2008-02-13 1:08 ` David Miller
2008-02-13 1:25 ` Bryan Henderson
2008-02-12 23:28 ` David Miller
2008-02-13 0:45 ` Theodore Tso
2008-02-12 20:50 ` David Miller
2008-02-12 9:23 ` CRC32C big endian bugs David Miller
2008-02-12 21:55 ` BTRFS only works with PAGE_SIZE <= 4K David Miller
2008-02-12 22:03 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211.224338.07019204.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=btrfs-devel@oss.oracle.com \
--cc=chris.mason@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.