From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Generic halt and reboot commands (was: Re: grub2 efi patches)
Date: Mon, 11 Feb 2008 15:11:44 +0100 [thread overview]
Message-ID: <20080211141144.GA20863@thorin> (raw)
In-Reply-To: <20080210215802.GC1165@boeglin.org>
On Sun, Feb 10, 2008 at 10:58:02PM +0100, Alexandre Boeglin wrote:
> Le dim 10 fév 2008 à 22:05:46 +0100, Robert Millan a écrit :
> > For consistency with similar code elsewhere in GRUB, I think it's better if
> > you made this:
> >
> > #if defined(foo)
> > #elif defined(bar)
> > #endif
>
> No whitespace before the opening bracket in this case ?
No. See how other parts of GRUB do it.
> By the way, this case is a good example of when it's 10 times easier to
> produce a patch with SVN than with CVS ;)
I know...
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2008-02-11 14:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 23:06 grub2 efi patches Alexandre Boeglin
2007-11-04 0:04 ` Alexandre Boeglin
2007-11-04 0:21 ` Alexandre Boeglin
2007-11-05 23:10 ` Alexandre Boeglin
2007-11-10 15:52 ` Marco Gerards
2007-11-10 15:48 ` Marco Gerards
2007-11-10 15:45 ` Marco Gerards
2007-11-18 18:14 ` Alexandre Boeglin
2007-12-18 20:16 ` Alexandre Boeglin
2008-01-23 11:39 ` Marco Gerards
2008-01-23 11:44 ` Robert Millan
2008-01-23 12:21 ` Marco Gerards
2008-01-24 8:35 ` Yoshinori K. Okuji
2008-01-24 9:12 ` Marco Gerards
2008-02-05 21:34 ` Alexandre Boeglin
2008-02-05 22:11 ` Robert Millan
2008-02-05 23:11 ` Alexandre Boeglin
2008-02-06 0:11 ` Robert Millan
2008-02-08 11:38 ` Alexandre Boeglin
2008-02-08 12:04 ` Robert Millan
2008-01-23 11:43 ` Robert Millan
2008-02-05 21:39 ` Alexandre Boeglin
2008-02-05 22:10 ` Robert Millan
2008-02-10 16:37 ` Generic halt and reboot commands (was: Re: grub2 efi patches) Alexandre Boeglin
2008-02-10 16:56 ` Robert Millan
2008-02-10 19:54 ` Alexandre Boeglin
2008-02-10 21:05 ` Robert Millan
2008-02-10 21:58 ` Alexandre Boeglin
2008-02-11 14:11 ` Robert Millan [this message]
2008-02-11 22:15 ` Alexandre Boeglin
2008-02-12 10:47 ` Robert Millan
2008-02-12 11:37 ` Alexandre Boeglin
2008-02-12 11:49 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211141144.GA20863@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.