From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JObIZ-0002IJ-Dm for mharc-grub-devel@gnu.org; Mon, 11 Feb 2008 11:14:27 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JObIX-0002HQ-7a for grub-devel@gnu.org; Mon, 11 Feb 2008 11:14:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JObIV-0002Gd-7f for grub-devel@gnu.org; Mon, 11 Feb 2008 11:14:24 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JObIU-0002GP-Io for grub-devel@gnu.org; Mon, 11 Feb 2008 11:14:22 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JObIU-0005aX-80 for grub-devel@gnu.org; Mon, 11 Feb 2008 11:14:22 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JObIR-0006TW-Vo for grub-devel@gnu.org; Mon, 11 Feb 2008 17:14:21 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JObGg-00022o-Lf for grub-devel@gnu.org; Mon, 11 Feb 2008 17:12:30 +0100 Date: Mon, 11 Feb 2008 17:12:30 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080211161230.GA7585@thorin> References: <47B06E4A.9070801@leat.rub.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47B06E4A.9070801@leat.rub.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Add option to grub-probe to accept system devices as arguments X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2008 16:14:25 -0000 On Mon, Feb 11, 2008 at 04:48:26PM +0100, Fabian Greffrath wrote: > >Is there really a need to strdup() it? > > Yep. If you return the pointer (i.e. to `path') you'll get memory > corruption as soon as you try to free (device_name). You put that function in a separate file, which indicates it is meant to be a general-purpose function, but its spec is constrained by the code in grub-probe (i.e. you strdup() not because it is needed for the purpose of this function, but because grub-probe already calls free()). In case of a general-purpose function, it doesn't make much sense to strdup it. Consider what would a caller have to do in case it wasn't using free() already: ret = check (device); if (! ret) fatal ("%s is bad", device); free (ret); instead of just: if (! check (device)) fatal ("%s is bad", device); > >I find it confusing that you change the meaning of the `path' variable > >without > >renaming it. Also, the variable that describes what `path' is > >(argument_is_device) is passed separately. > > Allright. Maybe the `path' variable should be renamed to `argument'. That works too ... but please put them together (i.e. both as arguments to probe()). > >I suspect advertising it here might lead users to think they can pass a > >device > >to it, without caring about [...] this option. > > Allright, this should be changed to something like this: > "Probe device information for a given path (or device, if the -d option is > given)." Ok. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)