From: Auke Kok <auke-jan.h.kok@intel.com>
To: jeff@garzik.org
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: [PATCH 3/6] e1000e: Fix logic reversal keeping link active
Date: Mon, 11 Feb 2008 09:25:51 -0800 [thread overview]
Message-ID: <20080211172551.29090.33075.stgit@localhost.localdomain> (raw)
In-Reply-To: <20080211172539.29090.99369.stgit@localhost.localdomain>
A logic mishap caused the adapter to keep link while we can
disable it due to WoL not being active, and vice versa.
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
---
drivers/net/e1000e/netdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index f58f017..b9b0d32 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -2008,7 +2008,7 @@ static void e1000_power_down_phy(struct e1000_adapter *adapter)
u16 mii_reg;
/* WoL is enabled */
- if (!adapter->wol)
+ if (adapter->wol)
return;
/* non-copper PHY? */
next prev parent reply other threads:[~2008-02-11 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 17:25 [PATCH 1/6] [NET] replace code with FIELD_SIZEOF Auke Kok
2008-02-11 17:25 ` [PATCH 2/6] e1000: warn if this driver is used for e1000e devices Auke Kok
2008-02-11 17:25 ` Auke Kok [this message]
2008-02-11 17:25 ` [PATCH 4/6] ixgbe: warn when device is in a x4 or lower width slot Auke Kok
2008-02-11 17:26 ` [PATCH 5/6] ixgbe: Disallow device reset during ethtool test Auke Kok
2008-02-11 17:26 ` [PATCH 6/6] ixgbe: remove accidentally added #ifdef Auke Kok
2008-02-11 19:51 ` [PATCH 1/6] [NET] replace code with FIELD_SIZEOF Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211172551.29090.33075.stgit@localhost.localdomain \
--to=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.