All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Alessandro Suardi <alessandro.suardi@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: 2.6.24-git2: Oracle 11g VKTM process enters R state on startup and is unkillable [still broken in 2.6.25-rc1]
Date: Mon, 11 Feb 2008 23:10:34 +0100	[thread overview]
Message-ID: <20080211221034.GA2587@elte.hu> (raw)
In-Reply-To: <20080211204921.GA24806@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> no, they were not lost, they just didnt pass QA here (they crashed on 
> a particularly hard to debug 8-way box i have) and Peter worked on 
> that queue of fixes up until today to get it really correct. Could you 
> check:
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git
> 
> combo patch below as well - whichever you prefer. The shortlog can be 
> found below as well - but i dont yet consider this pullable, i'd like 
> it to see pass a full night of randconfig tests on my test-systems.

ok, we just found the reason for the 8-way crash, the delta fix from 
Peter is below if any of you have tried the previous combo patch. 
Updated sched.git as well, new HEAD is 
fec13e45305d69fd0bd23b30bd05a0a42cf341f8.

	Ingo

Index: linux-2.6/kernel/sched.c
===================================================================
--- linux-2.6.orig/kernel/sched.c
+++ linux-2.6/kernel/sched.c
@@ -219,6 +219,10 @@ static void start_rt_bandwidth(struct rt
 	if (rt_b->rt_runtime == RUNTIME_INF)
 		return;
 
+	if (hrtimer_active(&rt_b->rt_period_timer))
+		return;
+
+	spin_lock(&rt_b->rt_runtime_lock);
 	for (;;) {
 		if (hrtimer_active(&rt_b->rt_period_timer))
 			break;
@@ -229,6 +233,7 @@ static void start_rt_bandwidth(struct rt
 			      rt_b->rt_period_timer.expires,
 			      HRTIMER_MODE_ABS);
 	}
+	spin_unlock(&rt_b->rt_runtime_lock);
 }
 
 #ifdef CONFIG_RT_GROUP_SCHED

  reply	other threads:[~2008-02-11 22:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 16:20 2.6.24-git2: Oracle 11g VKTM process enters R state on startup and is unkillable [still broken in 2.6.25-rc1] Alessandro Suardi
2008-02-11 19:09 ` Rafael J. Wysocki
2008-02-11 19:38   ` Linus Torvalds
2008-02-11 19:56     ` Rafael J. Wysocki
2008-02-11 20:49       ` Ingo Molnar
2008-02-11 22:10         ` Ingo Molnar [this message]
2008-02-11 23:12           ` Rafael J. Wysocki
2008-02-11 23:31             ` Alessandro Suardi
2008-02-13 12:28               ` Ingo Molnar
2008-02-12 13:44             ` Peter Zijlstra
2008-02-12 14:35               ` Alessandro Suardi
2008-02-12 14:53                 ` Peter Zijlstra
2008-02-12 19:28               ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080211221034.GA2587@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=alessandro.suardi@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.