From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JOpT9-0006i8-5u
	for mharc-grub-devel@gnu.org; Tue, 12 Feb 2008 02:22:19 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JOpT6-0006ho-NX
	for grub-devel@gnu.org; Tue, 12 Feb 2008 02:22:16 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JOpT4-0006hV-VB
	for grub-devel@gnu.org; Tue, 12 Feb 2008 02:22:16 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JOpT4-0006hS-Q4
	for grub-devel@gnu.org; Tue, 12 Feb 2008 02:22:14 -0500
Received: from ns39764.ovh.net ([91.121.25.85] helo=nexedi.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <okuji@enbug.org>) id 1JOpT4-000201-FI
	for grub-devel@gnu.org; Tue, 12 Feb 2008 02:22:14 -0500
Received: from [10.8.0.46] (unknown [10.8.0.46])
	by nexedi.com (Postfix) with ESMTP id C498A3D92A
	for <grub-devel@gnu.org>; Tue, 12 Feb 2008 08:29:35 +0100 (CET)
From: "Yoshinori K. Okuji" <okuji@enbug.org>
Organization: enbug.org
To: The development of GRUB 2 <grub-devel@gnu.org>
Date: Tue, 12 Feb 2008 08:22:11 +0100
User-Agent: KMail/1.9.4
References: <1202074413.560.7.camel@k9.localnet> <874pco90mm.fsf@xs4all.nl>
	<foqj2o$c28$1@ger.gmane.org>
In-Reply-To: <foqj2o$c28$1@ger.gmane.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802120822.11993.okuji@enbug.org>
X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3)
Subject: Re: [PATCH] to make grub2 compile on NetBSD
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Feb 2008 07:22:17 -0000

On Monday 11 February 2008 23:44, walt wrote:
> On Mon, 2008-02-04 at 16:56 +0100, Marco Gerards wrote:
> > walt <wa1ter@myrealbox.com> writes:
> > > NetBSD's gcc wants libgcc and libc to define __enable_execute_stack,
> > > but this is useless for a free-standing executable like grub.  Define
> > > a dummy function in lieu of libgcc to supply __enable_execute_stack.
> >
> > ...  If this is for NetBSD only,
> > shouldn't you add a #ifdef instead of a comment?
>
> Third try:
>
> 2008-??-??  walt <wa1ter@myrealbox.com>
>
> 	Make NetBSD's gcc happy.  Based on pkgsrc/wip/grub2 patches.
>
> 	* include/grub/mm.h
> 	[__NetBSD__] (__enable_execute_stack): New function prototype.
> 	* kern/mm.c
> 	[__NetBSD__] (__enable_execute_stack): New function.

I don't strongly object to this way, but I feel that it would be better to 
probe if __enable_execute_stack must be defined, and define a variable in 
configure, instead of hardcoding __NetBSD__.

Okuji