All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>,
	Len Brown <lenb@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled
Date: Tue, 12 Feb 2008 16:12:25 +0100	[thread overview]
Message-ID: <20080212151225.GA5415@elte.hu> (raw)
In-Reply-To: <alpine.LFD.1.00.0802112038360.2920@woody.linux-foundation.org>


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> @@ -673,11 +673,11 @@ static int __init acpi_wmi_init(void)
>  {
>  	acpi_status result;
>  
> +	INIT_LIST_HEAD(&wmi_blocks.list);
> +
>  	if (acpi_disabled)
>  		return -ENODEV;
>  
> -	INIT_LIST_HEAD(&wmi_blocks.list);
> -

test results: i've turned the WMI options back on earlier today on 
latest -git which has your patch above, and those crashes i reported 
disappeared. So the problem is fixed.

	Ingo

  reply	other threads:[~2008-02-12 15:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08  6:45 [GIT PATCH] ACPI patches for 2.6.25-rc0 (#2) Len Brown
2008-02-09  6:17 ` Ingo Molnar
2008-02-09  6:19   ` Ingo Molnar
2008-02-09  6:19   ` Ingo Molnar
2008-02-09 11:42     ` Carlos Corbacho
2008-02-11  9:17       ` Ingo Molnar
2008-02-11 19:23         ` Carlos Corbacho
2008-02-11 19:55           ` [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled Carlos Corbacho
2008-02-11 19:55           ` Carlos Corbacho
2008-02-12  4:41             ` Linus Torvalds
2008-02-12  4:41             ` Linus Torvalds
2008-02-12 15:12               ` Ingo Molnar [this message]
2008-02-12 15:12               ` Ingo Molnar
2008-02-12 19:28               ` Carlos Corbacho
2008-02-12 19:28               ` Carlos Corbacho
2008-02-11 19:55           ` [PATCH 2/2] tc1100-wmi " Carlos Corbacho
2008-02-11 19:55           ` Carlos Corbacho
2008-02-14  6:11             ` Len Brown
2008-02-14  6:15               ` Len Brown
2008-02-14  6:15               ` Len Brown
2008-02-14  6:11             ` Len Brown
2008-02-11 19:23         ` [GIT PATCH] ACPI patches for 2.6.25-rc0 (#2) Carlos Corbacho
2008-02-11  9:17       ` Ingo Molnar
2008-02-09 11:42     ` Carlos Corbacho
2008-02-09  6:17 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080212151225.GA5415@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=carlos@strangeworlds.co.uk \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.