From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 12 Feb 2008 16:26:34 +0100
Subject: [U-Boot-Users] [PATCH 2/3] fdt: Fixup compile error and add a
	new OF manipulation option
In-Reply-To: <47B1B40F.3040301@ge.com>
References: <20080212011159.769c0edb@neuromancer.mindspace>
	<20080212141645.32631da9@neuromancer.mindspace>
	<47B1B40F.3040301@ge.com>
Message-ID: <200802121626.34928.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Jerry,

On Tuesday 12 February 2008, Jerry Van Baren wrote:
> I think you have an older version of fdt_support.c.  Check the latest
> version - the above check is no longer in there.  That was a change that
> went in towards the end of the last patch window.
>
> <http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=common/fdt_sup
>port.c;h=92f1c7f54fd5e62942c8496bde52639e420067c1;hb=HEAD>
>
> The patch that changed this:
> <http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=b60af3d4
>c1680487ee37e11aa1b3db6dec04d8f0>
>
> It is possible we have some other wires crossed as well.  There was a
> fair amount of LIBFDT support refactoring going on in the last patch
> window, so we may have missed some deletions related to refactoring that
> should have been made.

I have to admit, that without looking too deep into the fdt code, I don't see 
a way to set the force flag upon Linux booting. Here the code from 
common/cmd_bootm.c:

        /*
         * Add the chosen node if it doesn't exist, add the env and bd_t
         * if the user wants it (the logic is in the subroutines).
         */
        if (of_flat_tree) {
                if (fdt_chosen(of_flat_tree, initrd_start, initrd_end, 0) < 0)

As you can see, the force flag is always set to 0. So how should "force" the 
chosen node manipulation? Perhaps I'm missing something here.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
=====================================================================