From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JPJlw-0003Kl-7J for mharc-grub-devel@gnu.org; Wed, 13 Feb 2008 10:43:44 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JPJlu-0003J8-J2 for grub-devel@gnu.org; Wed, 13 Feb 2008 10:43:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JPJls-0003Hb-PM for grub-devel@gnu.org; Wed, 13 Feb 2008 10:43:42 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JPJls-0003HR-HH for grub-devel@gnu.org; Wed, 13 Feb 2008 10:43:40 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JPJls-000782-7I for grub-devel@gnu.org; Wed, 13 Feb 2008 10:43:40 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JPJld-0006HY-OT for grub-devel@gnu.org; Wed, 13 Feb 2008 16:43:27 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JPJiz-0007pf-7k for grub-devel@gnu.org; Wed, 13 Feb 2008 16:40:41 +0100 Date: Wed, 13 Feb 2008 16:40:41 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080213154041.GA30040@thorin> References: <1202766709.5108.7.camel@k9.localnet> <20080212111902.GC18073@thorin> <20080212193650.GA3319@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] a.out support for multiboot and freebsd X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2008 15:43:42 -0000 On Wed, Feb 13, 2008 at 06:40:14PM +0800, Bean wrote: > On Feb 13, 2008 3:36 AM, Robert Millan wrote: > > On Wed, Feb 13, 2008 at 02:47:30AM +0800, Bean wrote: > > > + /* ... and put our return address in its place (the kernel will ignore > > > + it, but it expects %esp to point to it. */ > > > + call *%eax > > > > Unmatched parenthesis here (sorry I guess that's my fault ;-)). > > Ok. I also fix the alloc magic broken problem, it's caused by > grub_elf_file, which will close the file when the elf magic is not > found. However, the upper level still use that file, that cause the > memory problem. > > The patch should be applied after the previous bsd.diff. You forgot the ChangeLog entry.. > --- a/loader/multiboot2.c > +++ b/loader/multiboot2.c > @@ -371,6 +371,7 @@ grub_multiboot2 (int argc, char *argv[]) > } > else > { > + grub_errno = 0; > grub_dprintf ("loader", "Loading non-ELF multiboot 2 file.\n"); > > if (header) Why this? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)