All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] fbfront: Fix no-kbd-event case
Date: Wed, 13 Feb 2008 16:03:16 +0000	[thread overview]
Message-ID: <20080213160316.GE10579@implementation.uk.xensource.com> (raw)

fbfront: Fix no-kbd-event case
out_cons shouldn't even be used.

Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>

diff -r f76e90b4f7ad drivers/xen/fbfront/xenkbd.c
--- a/drivers/xen/fbfront/xenkbd.c	Tue Feb 12 10:44:33 2008 +0000
+++ b/drivers/xen/fbfront/xenkbd.c	Wed Feb 13 15:59:45 2008 +0000
@@ -53,7 +53,7 @@ static irqreturn_t input_handler(int rq,
 	__u32 cons, prod;
 
 	prod = page->in_prod;
-	if (prod == page->out_cons)
+	if (prod == page->in_cons)
 		return IRQ_HANDLED;
 	rmb();			/* ensure we see ring contents up to prod */
 	for (cons = page->in_cons; cons != prod; cons++) {

             reply	other threads:[~2008-02-13 16:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 16:03 Samuel Thibault [this message]
2008-02-13 17:49 ` [PATCH] fbfront: Fix no-kbd-event case Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080213160316.GE10579@implementation.uk.xensource.com \
    --to=samuel.thibault@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.