From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] coretemp: Add maximum cooling temperature
Date: Wed, 13 Feb 2008 20:35:33 +0000 [thread overview]
Message-ID: <20080213213533.7cc9415b@hyperion.delvare> (raw)
Hi Rudolf,
On Fri, 18 Jan 2008 00:42:54 +0100, Rudolf Marek wrote:
> This patch updates my previous patch with Jeans valuable comments - yeah thanks!
> Compile tested this time.
>
> Following patch will add reporting of maximum temperature, at which all fans
> should spin full speed. It may be non-physical temperature on Desktop/Server CPUs.
>
> Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Tested on my Core T2600, it doesn't have the feature but at least I
confirm that there is no regression.
I reviewed the code, it looks OK to me this time.
Acked-by: Jean Delvare <khali@linux-fr.org>
Just one comment:
> + err = device_create_file(&pdev->dev,
> + &sensor_dev_attr_temp1_max.dev_attr);
It should be possible to make this line fit in the 80-column limit.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2008-02-13 20:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 20:35 Jean Delvare [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-17 23:42 [lm-sensors] [PATCH] coretemp: Add maximum cooling temperature Rudolf Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213213533.7cc9415b@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.