From: "Ed L. Cashin" <ecashin@coraid.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Jan Engelhardt <jengelh@computergmbh.de>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] #if 0 aoedev_isbusy()
Date: Wed, 13 Feb 2008 17:56:53 -0500 [thread overview]
Message-ID: <20080213225653.GK4355@coraid.com> (raw)
In-Reply-To: <20080213220537.GA24319@cs181133002.pp.htv.fi>
On Thu, Feb 14, 2008 at 12:05:37AM +0200, Adrian Bunk wrote:
> On Wed, Feb 13, 2008 at 11:03:35PM +0100, Jan Engelhardt wrote:
> >
> > On Feb 13 2008 23:30, Adrian Bunk wrote:
> > >
> > >This patch #if 0's the no longer used aoedev_isbusy().
> >
> > Why not just remove it? (It can be resurrected from earlier
> > revisions should it be needed again.)
>
> I've switched to doing #if 0 instead since this addresses the
> "It might be needed in the future." answer I otherwise sometimes
> got.
>
> But if a maintainer wants to have such a function deleted instead that's
> fine with me.
Hello. That function can go away. I have some changes pending, but
none of them use aoedev_isbusy. Thanks for Cc-ing me.
--
Ed L Cashin <ecashin@coraid.com>
next prev parent reply other threads:[~2008-02-13 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 21:30 [2.6 patch] #if 0 aoedev_isbusy() Adrian Bunk
2008-02-13 22:03 ` Jan Engelhardt
2008-02-13 22:05 ` Adrian Bunk
2008-02-13 22:56 ` Ed L. Cashin [this message]
2008-02-14 21:23 ` [2.6 patch] remove aoedev_isbusy() Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213225653.GK4355@coraid.com \
--to=ecashin@coraid.com \
--cc=bunk@kernel.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.