From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: use ctrl_in/out for on chip pci access
Date: Thu, 14 Feb 2008 05:23:24 +0000 [thread overview]
Message-ID: <20080214052324.GB12436@linux-sh.org> (raw)
In-Reply-To: <20080214045243.6842.31222.sendpatchset@clockwork.opensource.se>
On Thu, Feb 14, 2008 at 01:52:43PM +0900, Magnus Damm wrote:
> This patch makes sure ctrl_inN/outN are used instead of inN/outN for on chip
> pci registers. Without this patch addresses may be adjusted using the value
> in generic_io_base. This patch makes it possible to set generic_io_base and
> have pci without reading and writing all over the place.
On Thu, Feb 14, 2008 at 01:59:02PM +0900, Magnus Damm wrote:
> This patch is a fix to make sure readsN/writesN are used over insN/outsN for
> ioreadN_rep/iowriteN_rep.
>
> The current state of the sh io code is that mmio operations like readN/writeN
> and ioreadN/iowriteN are unaffected by the value of generic_io_base. This is
> different fom port based io like inN/outN which gets adjusted using the value
> in generic_io_base.
>
> Without this patch ioreadN_rep/iowriteN_rep get their addresses adjusted.
> The address for mmio access is adjusted using generic_io_base. This is wrong.
> The ata core code currently crashes if generic_io_base is set.
>
> This patch changes ioreadN_rep/iowriteN_rep to follow the same rules as the
> rest of the mmio operations, ie don't adjust using generic_io_base.
On Thu, Feb 14, 2008 at 02:05:57PM +0900, Magnus Damm wrote:
> Use generic_io_base to point out the pci io window, and make sure the
> highest port address used is SH7751_PCI_IO_SIZE - 1.
>
> This patch fixes pci io port access for the r2d boards - CONFIG_8139TOO_PIO
> now works as expected. So does the alsa driver for CMI8738.
Applied, thanks.
prev parent reply other threads:[~2008-02-14 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 4:52 [PATCH] sh: use ctrl_in/out for on chip pci access Magnus Damm
2008-02-14 5:23 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214052324.GB12436@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.