All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] 440EPX is not booting from 1Gb/128MB NAND flash
Date: Thu, 14 Feb 2008 06:36:35 +0100	[thread overview]
Message-ID: <200802140636.35605.sr@denx.de> (raw)
In-Reply-To: <e9eeaac20802131516h3231fed1n502f17cb5e23c311@mail.gmail.com>

Hi Nikhil.

On Thursday 14 February 2008, Nikhil Gautam wrote:
> Thanks for all the help in solving the problem. I have some questions
> about submitting the patch and testing of the patch.
>
> First of all I am working on proprietary board based on AMCC sequoia
> board.

You need to create a new board port for your custom board. This could be done 
by "cloning" the Sequoia port and modifying it.

> Hence some of the files I changed are module specific like 
> config.mk in nand_spl/board/....and I also modified the following
> lines in u-boot-nand.lds
>
>     cpu/ppc4xx/start.o	(.text)
>
>     /* Align to next NAND block */
>     . = ALIGN(0x20000);
>     common/environment.o  (.ppcenv)
>     /* Keep some space here for redundant env and potential bad env blocks
> */ . = ALIGN(0x80000);
>
> Above is to allow some space for u-boot environment and possible bad
> blocks. This file is also module specific.

Right. All this should *not* go into the Sequoia port but into your new board 
port. The infrastructure is ready for it.

> Besides these two files I have changed nand_boot.c and ndfc.c.

Sure. These are probably the only common changes needed.

> Considering all this, how should I create this patch. Should I create
> a patch for the sequoia board?

*NO*. Please don't. Create you own board port.

> Also how are we going to test this patch? I'll make sure it meets all
> the requirement in terms of coding style, etc but as far as testing
> goes, I can only test on my board because sequoia reference board
> comes only with 256Mb NAND flash.

You will test this on your board and I (or somebody else) will test it on 
already supported NAND booting platforms.

Hope this helps.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2008-02-14  5:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07  0:36 440EPX is not booting from 1Gb/128MB NAND flash Nikhil Gautam
2008-02-07  0:38 ` [U-Boot-Users] " Nikhil Gautam
2008-02-07  5:24   ` Stefan Roese
2008-02-07 23:46     ` Nikhil Gautam
2008-02-08  4:50       ` Stefan Roese
2008-02-08 22:57         ` Nikhil Gautam
2008-02-09  5:51           ` Stefan Roese
2008-02-11 14:43           ` Nikhil Gautam
2008-02-11 16:26             ` Stefan Roese
2008-02-12  1:16               ` Nikhil Gautam
2008-02-12  5:12                 ` Stefan Roese
2008-02-12  6:02                   ` Wolfgang Denk
2008-02-12  6:11                     ` Stefan Roese
2008-02-12 22:31                       ` Wolfgang Denk
2008-02-13 23:16                         ` Nikhil Gautam
2008-02-14  5:36                           ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802140636.35605.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.