From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
Sven K?hler <skoehler@upb.de>,
Christoph Hellwig <hch@infradead.org>,
Jeff Garzik <jeff@garzik.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel@vger.kernel.org, Joerg Dorchain <joerg@dorchain.net>,
Jon Chelton <jchelton@ffpglobal.com>,
Stefan Priebe - allied internet ag <s.priebe@allied-internet.ag>
Subject: Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash
Date: Thu, 14 Feb 2008 01:51:01 -0500 [thread overview]
Message-ID: <20080214065101.GA19294@infradead.org> (raw)
In-Reply-To: <1202922226.3109.36.camel@localhost.localdomain>
On Wed, Feb 13, 2008 at 11:03:45AM -0600, James Bottomley wrote:
> > I don't understand please explain.
> > What does a driver need to do if it needs a consistent shutdown retine?
> > module or built in? unload or shutdown?
>
> It needs to register a reboot notifier, which gdth does.
Well, for crappy legacy driver that's the way, but it's not really
recommended. As soon as a driver uses the proper driver models,
e.g. gdth for pci using Jeff's pci hotplug patches it can just
implement the ->shutdown method that is called before shutdown/kexec
and can do the right thing.
prev parent reply other threads:[~2008-02-14 6:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 19:47 [BUG?] GDTH driver not working after upgrade to 2.6.24 Sven Köhler
2008-01-31 10:08 ` Boaz Harrosh
2008-01-31 10:08 ` Boaz Harrosh
2008-01-31 11:07 ` Sven Köhler
2008-01-31 12:35 ` Boaz Harrosh
2008-01-31 12:35 ` Boaz Harrosh
2008-01-31 16:39 ` Jan Engelhardt
2008-01-31 16:52 ` Boaz Harrosh
2008-02-12 17:30 ` [BUGFIXES 0/2] gdth: fix 2.6.24 driver breakage Boaz Harrosh
2008-02-12 17:30 ` Boaz Harrosh
2008-02-12 17:35 ` [BUGFIX 1/2] gdth: scan for scsi devices Boaz Harrosh
2008-02-12 17:35 ` Boaz Harrosh
2008-02-12 18:05 ` Christoph Hellwig
2008-02-12 17:40 ` [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash Boaz Harrosh
2008-02-13 7:06 ` Stefan Priebe - allied internet ag
2008-02-13 9:03 ` Boaz Harrosh
2008-02-13 19:38 ` Jan Engelhardt
2008-02-14 15:58 ` Boaz Harrosh
2008-02-13 10:48 ` Boaz Harrosh
2008-02-13 15:44 ` James Bottomley
2008-02-13 15:54 ` Boaz Harrosh
2008-02-13 16:33 ` Boaz Harrosh
2008-02-13 16:35 ` [PATCH ver2] gdth: bugfix for the at-exit problems Boaz Harrosh
2008-02-13 16:45 ` [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash James Bottomley
2008-02-13 16:50 ` Boaz Harrosh
2008-02-13 17:03 ` James Bottomley
2008-02-13 17:12 ` Boaz Harrosh
2008-02-13 17:36 ` James Bottomley
2008-02-14 10:49 ` Boaz Harrosh
2008-02-14 11:58 ` [PATCH] gdth: bugfix for the at-exit problems Boaz Harrosh
2008-02-14 16:10 ` James Bottomley
2008-02-14 16:18 ` Boaz Harrosh
2008-02-13 17:18 ` [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash Boaz Harrosh
2008-02-13 17:33 ` James Bottomley
2008-02-14 6:51 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214065101.GA19294@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bharrosh@panasas.com \
--cc=jchelton@ffpglobal.com \
--cc=jeff@garzik.org \
--cc=joerg@dorchain.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=s.priebe@allied-internet.ag \
--cc=skoehler@upb.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.