From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dan Magenheimer" Subject: RE: [PATCH] new hvm platform vhpet enable parameter Date: Thu, 14 Feb 2008 09:52:26 -0700 Message-ID: <20080214095226125.00000001516@djm-pc> References: <20080207135345296.00000003652@djm-pc> Reply-To: "dan.magenheimer@oracle.com" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20080207135345296.00000003652@djm-pc> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org I see this patch hasn't been taken yet. Is there something else I need to do or are you not in agreement that the acpi part is cosmetic? Thanks, Dan > -----Original Message----- > From: Dan Magenheimer [mailto:dan.magenheimer@oracle.com] > Sent: Thursday, February 07, 2008 1:54 PM > To: 'Keir Fraser'; 'xen-devel@lists.xensource.com' > Subject: RE: [Xen-devel] [PATCH] new hvm platform vhpet = > enable parameter > = > = > > Yes, tools/firmware/hvmloader/acpi/dsdt.asl. The right way to = > > do this will > > be to gate it on a flag set up in memory by hvmloader (we = > > already do this > > e.g., for com1 and com2 -- see construct_bios_info_table() in = > > build.c in the > > same directory). That might be a bit tricky as it probably = > > needs a bit of > > ASL hacking, which has a little learning curve. I can take a = > > look maybe next > > week. > = > OK, here's the updated patch: > 1) hpet instead of vhpet > 2) against 3.2-testing tip > = > This will work without the acpi changes so could be checked in > independently. Though it may be a bit misleading for the > guest to print out that it found an hpet in acpi and then > be unable to use it, the acpi part is largely cosmetic > and (as you point out) a bit tricky so better left for > your capable hands. > = > Thanks, > Dan >