From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>, Tejun Heo <htejun@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 11/11] ata: fix sparse warnings in pata_legacy.c
Date: Thu, 14 Feb 2008 12:02:06 +0000 [thread overview]
Message-ID: <20080214120206.1a52f77d@core> (raw)
In-Reply-To: <1202966072.2748.27.camel@brick>
On Wed, 13 Feb 2008 21:14:32 -0800
Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Let's use ld for legacy_data instead of shadowing these static
> int variables.
NAK - I purposefully used names that indicate what device the private
data is being used for in order to make it clear. Changing qdi and
winbond to ld_qdi and ld_winbond would avoid that and fix the shadowing
of the static value.
Alan
next prev parent reply other threads:[~2008-02-14 12:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3ad7c41048d88a3f8aad098570b9fac9ff719aff.1202965399.git.harvey.harrison@gmail.com>
2008-02-14 5:14 ` [PATCH 02/11] ata: fix sparse warning in sata_promise.c Harvey Harrison
2008-02-14 5:14 ` [PATCH 03/11] ata: fix sparse warning in sata_via.c Harvey Harrison
2008-02-14 5:14 ` [PATCH 04/11] ata: fix sparse warnings in sata_mv.c Harvey Harrison
2008-02-14 5:14 ` [PATCH 05/11] ata: replace macro with static inline in libata.h Harvey Harrison
2008-02-14 12:01 ` Alan Cox
2008-02-14 17:38 ` Harvey Harrison
2008-02-14 18:11 ` [PATCH 05/11v2] " Harvey Harrison
2008-02-14 5:14 ` [PATCH 06/11] ata: sparse fixes for pata_amd.c Harvey Harrison
2008-02-15 18:52 ` Jeff Garzik
2008-02-14 5:14 ` [PATCH 07/11] ata: fix sparse warning in pata_cs5536.c Harvey Harrison
2008-02-14 5:14 ` [PATCH 08/11] ata: fix sparse warning in pata_jmicron.c Harvey Harrison
2008-02-14 5:14 ` [PATCH 09/11] ata: fix sparse warning in pata_marvell.c Harvey Harrison
2008-02-15 14:29 ` Jan Engelhardt
2008-02-14 5:14 ` [PATCH 10/11] ata: fix sparse warning in pata_acpi.c Harvey Harrison
2008-02-14 5:14 ` [PATCH 11/11] ata: fix sparse warnings in pata_legacy.c Harvey Harrison
2008-02-14 12:02 ` Alan Cox [this message]
2008-02-14 17:36 ` [PATCH 11/11v2] " Harvey Harrison
2008-02-14 17:56 ` Alan Cox
2008-02-20 17:09 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214120206.1a52f77d@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=harvey.harrison@gmail.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.