From: Pete Wyckoff <pw@osc.edu>
To: Mike Christie <michaelc@cs.wisc.edu>,
Erez Zilber <erezz@voltaire.com>,
Roland Dreier <rolandd@cisco.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH 1/3 v2] iscsi iser: remove DMA alignment restriction
Date: Thu, 14 Feb 2008 16:10:29 -0500 [thread overview]
Message-ID: <20080214211029.GA21073@osc.edu> (raw)
In-Reply-To: <20080213195912.GC7372@osc.edu>
Thanks to James pointing out the problems with the BLK_BOUNCE_ANY
for IB devices, this revised patch contains only the DMA alignment
fix for iSER.
Mike, can you take care of this and the other two patches in the
series:
[PATCH 2/3] iscsi iser: increase max_sectors
[PATCH 3/3] iscsi iser: increase sg_tablesize
-- Pete
>From 255e73b67ec1458af18395981fddebdc958e8fe9 Mon Sep 17 00:00:00 2001
From: Pete Wyckoff <pw@osc.edu>
Date: Thu, 14 Feb 2008 16:09:27 -0500
Subject: [PATCH] iscsi iser: remove DMA alignment restriction
iscsi_iser does not require any particular DMA aligement
requirement. Add a slave_configure function to set the alignment
to zero, allowing the use of direct IO from arbitrary offsets
within a page.
Signed-off-by: Pete Wyckoff <pw@osc.edu>
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index be1b9fb..313f102 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -543,6 +543,12 @@ iscsi_iser_ep_disconnect(__u64 ep_handle)
iser_conn_terminate(ib_conn);
}
+static int iscsi_iser_slave_configure(struct scsi_device *sdev)
+{
+ blk_queue_dma_alignment(sdev->request_queue, 0);
+ return 0;
+}
+
static struct scsi_host_template iscsi_iser_sht = {
.module = THIS_MODULE,
.name = "iSCSI Initiator over iSER, v." DRV_VER,
@@ -556,6 +562,7 @@ static struct scsi_host_template iscsi_iser_sht = {
.eh_device_reset_handler= iscsi_eh_device_reset,
.eh_host_reset_handler = iscsi_eh_host_reset,
.use_clustering = DISABLE_CLUSTERING,
+ .slave_configure = iscsi_iser_slave_configure,
.proc_name = "iscsi_iser",
.this_id = -1,
};
--
1.5.3.8
next prev parent reply other threads:[~2008-02-14 21:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 20:52 [PATCH 0/3] iscsi iser limits Pete Wyckoff
2008-02-12 20:54 ` [PATCH 1/3] iscsi iser: remove DMA restrictions Pete Wyckoff
2008-02-12 21:10 ` James Bottomley
2008-02-12 21:46 ` Pete Wyckoff
2008-02-12 21:57 ` James Bottomley
2008-02-13 19:59 ` Pete Wyckoff
2008-02-14 21:10 ` Pete Wyckoff [this message]
2008-05-05 13:19 ` [PATCH 1/3 v2] iscsi iser: remove DMA alignment restriction Erez Zilber
2008-04-21 13:51 ` [PATCH 1/3] iscsi iser: remove DMA restrictions Erez Zilber
2008-04-23 13:41 ` [ofa-general] " Erez Zilber
2008-04-23 16:33 ` Mike Christie
2008-04-23 17:16 ` Mike Christie
2008-04-23 17:43 ` Mike Christie
2008-02-14 17:56 ` Mike Christie
2008-02-14 18:10 ` James Bottomley
2008-02-14 18:21 ` Mike Christie
2008-02-14 18:34 ` Mike Christie
2008-02-14 19:04 ` Mike Christie
2008-02-12 20:54 ` [PATCH 2/3] iscsi iser: increase max_sectors Pete Wyckoff
2008-05-05 13:36 ` Erez Zilber
2008-05-05 20:43 ` Roland Dreier
2008-05-05 17:49 ` Mike Christie
2008-05-07 15:53 ` Pete Wyckoff
2008-05-12 12:10 ` Erez Zilber
2008-02-12 20:54 ` [PATCH 3/3] iscsi iser: increase sg_tablesize Pete Wyckoff
2008-03-02 13:56 ` [PATCH 0/3] iscsi iser limits Erez Zilber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214211029.GA21073@osc.edu \
--to=pw@osc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=erezz@voltaire.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.