All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@MIT.EDU>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, linux-ext4@vger.kernel.org
Subject: Re: [RFC/PATCH] ext4: Request for journal write access early.
Date: Fri, 15 Feb 2008 15:30:01 -0500	[thread overview]
Message-ID: <20080215203001.GA7664@mit.edu> (raw)
In-Reply-To: <1202985052-15694-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

On Thu, Feb 14, 2008 at 04:00:52PM +0530, Aneesh Kumar K.V wrote:
> In ext4_ext_convert_to_initialized before we need to request for journal
> write access before we even modify the extent length.

This isn't a grammatically correct sentence, and it doesn't explain
what is going on.  I rewrote the patch description as follows:

   ext4: Get journal write access before modifying the extent tree

   When the user was writing into an unitialized extent,
   ext4_ext_convert_to_initialize() was not requesting journal write access
   before it started to modify the extent tree.   Fix this oversight.

   	     	     	       	   	  	  - Ted

  parent reply	other threads:[~2008-02-16  0:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14 10:30 [RFC/PATCH] ext4: Fix the memory leak and buffer head leak with respect to ext4_ext_path Aneesh Kumar K.V
2008-02-14 10:30 ` [RFC/PATCH] ext4: Request for journal write access early Aneesh Kumar K.V
2008-02-14 18:46   ` Mingming Cao
2008-02-14 23:21   ` Mingming Cao
2008-02-15 20:30   ` Theodore Tso [this message]
2008-02-14 18:34 ` [RFC/PATCH] ext4: Fix the memory leak and buffer head leak with respect to ext4_ext_path Mingming Cao
2008-02-14 23:21 ` Mingming Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080215203001.GA7664@mit.edu \
    --to=tytso@mit.edu \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.