All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stephen Neuendorffer" <stephen.neuendorffer@xilinx.com>
To: "Sergei Shtylyov" <sshtylyov@ru.mvista.com>,
	"Grant Likely" <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, Pavel Kiryukhin <pkiryukhin@ru.mvista.com>
Subject: RE: [PATCH] booting-without-of: add Xilinx uart 16550.
Date: Fri, 15 Feb 2008 13:40:17 -0800	[thread overview]
Message-ID: <20080215214018.EA724CB0046@mail174-sin.bigfish.com> (raw)
In-Reply-To: <47B5E042.9050805@ru.mvista.com>


> > Instead of attempting to come up with a generic description
> > of this, I recommend just naming it after the actual device
instance;
> > something like compatible=3D"xlnx,opb-uart16550";
>=20
>     Well, that means that we'll need a to add a code which "glues" the
chip to
> 8250.c driver... well, of_serial.c could be that glue layer if we add
to it
> the ability to recognize Xilinx UART... well, legacy_serial.c could be
taught
> that trick too...
>     Well, we could also add the new compatible, but still claim
"ns16550"
> compatibility...

This actually makes more sense to me...  I'd rather have the code set
the reg-shift than have it explicitly set in the device tree anyway.
The compatibility set should include (at the least):

      opb_uart16550_v1_00_c
      opb_uart16550_v1_00_d
      opb_uart16550_v1_00_e
      plb_uart16550_v1_00_c
      xps_uart16550_v1_00_a

I think this is somewhat independent of Sergei's arguments that generic
ns16550 devices should allow having a reg-shift set....

Steve

  parent reply	other threads:[~2008-02-15 21:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15 13:40 [PATCH] booting-without-of: add Xilinx uart 16550 Pavel Kiryukhin
2008-02-15 17:08 ` Stephen Neuendorffer
2008-02-15 17:41   ` Pavel Kiryukhin
2008-02-15 17:46     ` Stephen Neuendorffer
2008-02-15 18:34 ` Milton Miller
2008-02-15 18:38 ` Grant Likely
2008-02-15 18:56   ` Sergei Shtylyov
2008-02-15 19:02     ` Grant Likely
2008-02-15 19:14       ` Sergei Shtylyov
2008-02-15 19:33         ` Grant Likely
2008-02-15 21:40     ` Stephen Neuendorffer [this message]
2008-02-18 19:47       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080215214018.EA724CB0046@mail174-sin.bigfish.com \
    --to=stephen.neuendorffer@xilinx.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=pkiryukhin@ru.mvista.com \
    --cc=sshtylyov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.