From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [RFC] Add vfsmount to vfs helper functions.
Date: Mon, 18 Feb 2008 00:40:43 +0000
Message-ID: <20080218004043.GV27894@ZenIV.linux.org.uk>
References: <4799B808.8080002@nttdata.co.jp> <20080130130006.GH27894@ZenIV.linux.org.uk> <200802022323.GIH52668.OFLVSQOFOtJMHF@I-love.SAKURA.ne.jp> <200802171800.EBB69708.MOSFQOJHOLFtFV@I-love.SAKURA.ne.jp> <20080217233852.GU27894@ZenIV.linux.org.uk> <200802180003.m1I03pIl018540@www262.sakura.ne.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org,
	linux-security-module@vger.kernel.org
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Return-path: <linux-security-module-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <200802180003.m1I03pIl018540@www262.sakura.ne.jp>
Sender: linux-security-module-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Mon, Feb 18, 2008 at 09:03:51AM +0900, Tetsuo Handa wrote:
> Hello.
> 
> > No printable comments, except for that:
> > 
> > (e) why don't you guys move the Linus' Serious Mistake to _callers_ of
> > vfs_mknod() and its ilk?
> > 
> > Which obviously solves all problems with having vfsmount.
> 
> Excuse me. I didn't understand what "the Linus' Serious Mistake to
> _callers_ of vfs_mknod()" is. Could you give me some URLs or hints?

Linus' Serious Mistake: LSM.

Moving that junk to callers for vfs_mknod(): should be obvious; remove
the calls of security_whatever() from vfs_...() and add them in places
that call the functions in question.