From: Ingo Molnar <mingo@elte.hu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "David P. Reed" <dpreed@reed.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86: fix pcspkr to not use inb_p/outb_p calls.
Date: Mon, 18 Feb 2008 04:12:02 +0100 [thread overview]
Message-ID: <20080218031202.GD30201@elte.hu> (raw)
In-Reply-To: <20080217222329.1152d689@core>
* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Sun, 17 Feb 2008 16:56:42 -0500 (EST)
> "David P. Reed" <dpreed@reed.com> wrote:
>
> > Fix pcspkr driver to use explicit timing delay for access to PIT,
> > rather than inb_p/outb_p calls, which use insufficiently explicit
>
> NAK.
>
> We now have inb_pit and outb_pit to make the transition easier - can
> you switch to those instead of coding internal knowledge outside of
> the kernel methods.
please also Cc: Dmitry Torokhov <dtor_core@ameritech.net> to
drivers/input/ patches. Once inb_pit/outb_pit is used, as suggested by
Alan, i ack the patch from the arch/x86 perspective.
Ingo
prev parent reply other threads:[~2008-02-18 3:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 21:56 [PATCH 3/3] x86: fix pcspkr to not use inb_p/outb_p calls David P. Reed
2008-02-17 22:23 ` Alan Cox
2008-02-18 3:12 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080218031202.GD30201@elte.hu \
--to=mingo@elte.hu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dpreed@reed.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.