From: Andi Kleen <ak@suse.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Andy Whitcroft <andyw@uk.ibm.com>
Subject: Re: [patch] checkpatch.pl: revert wrong --file message
Date: Mon, 18 Feb 2008 11:16:42 +0100 [thread overview]
Message-ID: <200802181116.42824.ak@suse.de> (raw)
In-Reply-To: <alpine.LFD.1.00.0802161026550.7583@apollo.tec.linutronix.de>
> People, who do cleanups - I'm not talking about running lindent here -
> read through the code while they fix it up.
Please feel free to repeat my little experiment: give someone who sends
you a lot of checkpatch.pl only patches a simple task that actually
requires a little actual code change and at least a little localized
understanding of code. See how well they do.
In my case it was the "turn ->ioctl into ->unlocked_ioctl" task,
which was simple enough.
I found that there were a lot of useful unlocked_ioctl patches
in the end, but they all only came from people who hadn't submitted
any checkpatch.pl only patches before.
-Andi
prev parent reply other threads:[~2008-02-18 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 16:52 [patch] checkpatch.pl: revert wrong --file message Ingo Molnar
2008-02-15 17:15 ` Andi Kleen
2008-02-16 10:18 ` Thomas Gleixner
2008-02-16 10:27 ` Pekka Enberg
2008-02-16 11:04 ` Cyrill Gorcunov
2008-02-16 22:56 ` Andy Whitcroft
2008-02-16 23:47 ` Thomas Gleixner
2008-02-18 10:07 ` Andi Kleen
2008-02-18 10:16 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802181116.42824.ak@suse.de \
--to=ak@suse.de \
--cc=andyw@uk.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.