From: Clemens Buchacher <drizzd@aon.at>
To: git@vger.kernel.org
Subject: [PATCH] http-push: Fix error message for push <remote> :<branch>
Date: Mon, 18 Feb 2008 14:07:26 +0100 [thread overview]
Message-ID: <20080218130726.GA26854@localhost> (raw)
git http-push <remote> :<branch> currently fails with the error message
"cannot happen anymore". Print a more useful error message instead.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
We should actually support this feature, of course. Unfortunately, a lot has
changed since the version of send-pack which http-push is based on
(v1.2.4-398-gaa1dbc9). I think http-push should be updated to reflect these
changes at a larger scope. Is there any work going on in this direction?
http-push.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/http-push.c b/http-push.c
index f9b77d6..8de091f 100644
--- a/http-push.c
+++ b/http-push.c
@@ -2311,6 +2311,15 @@ int main(int argc, char **argv)
if (!ref->peer_ref)
continue;
+
+ if (is_zero_sha1(ref->peer_ref->new_sha1)) {
+ error("Deleting remote branches via :<branch> is not "
+ "currently supported by http-push. Use git "
+ "http-push -d <remote-url> <branch> instead.");
+ rc = -2;
+ continue;
+ }
+
if (!hashcmp(ref->old_sha1, ref->peer_ref->new_sha1)) {
if (push_verbosely || 1)
fprintf(stderr, "'%s': up-to-date\n", ref->name);
--
1.5.4.2.183.g1ae81
next reply other threads:[~2008-02-18 13:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 13:07 Clemens Buchacher [this message]
2008-02-18 13:45 ` [PATCH] http-push: Fix error message for push <remote> :<branch> Johannes Schindelin
2008-02-18 15:55 ` [PATCH] http-push: push <remote> :<branch> deletes remote branch Clemens Buchacher
2008-02-18 16:44 ` Clemens Buchacher
2008-02-18 17:35 ` Johannes Schindelin
2008-02-18 17:34 ` Johannes Schindelin
2008-02-19 12:58 ` Clemens Buchacher
2008-02-19 13:17 ` Johannes Schindelin
2008-02-19 13:24 ` Mike Hommey
2008-02-19 13:31 ` Johannes Schindelin
2008-02-19 21:35 ` Junio C Hamano
2008-02-19 22:25 ` Johannes Schindelin
2008-02-23 21:28 ` [PATCH] http-push: add regression tests Clemens Buchacher
2008-02-24 8:58 ` Mike Hommey
2008-02-24 18:03 ` Clemens Buchacher
2008-02-24 18:48 ` Mike Hommey
2008-02-24 19:14 ` Clemens Buchacher
2008-02-25 23:28 ` Clemens Buchacher
2008-02-26 0:24 ` Junio C Hamano
2008-02-27 8:54 ` Clemens Buchacher
2008-02-27 9:16 ` Mike Hommey
2008-02-27 9:51 ` Johannes Schindelin
2008-02-27 19:23 ` Clemens Buchacher
2008-02-27 19:27 ` [PATCH 1/2] http-push: push <remote> :<branch> deletes remote branch Clemens Buchacher
2008-02-27 19:28 ` [PATCH 2/2] http-push: add regression tests Clemens Buchacher
2008-02-27 22:24 ` [PATCH] " Johannes Schindelin
2008-02-26 19:32 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080218130726.GA26854@localhost \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.