All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Theodore Tso <tytso@mit.edu>, Andreas Dilger <adilger@sun.com>,
	Adrian Bunk <bunk@kernel.org>,
	sct@redhat.com, akpm@linux-foundation.org,
	linux-ext4@vger.kernel.org, linux-kernel@vger
Subject: Re: [2.6 patch] fs/jbd/journal.c: cleanups
Date: Mon, 18 Feb 2008 14:55:09 +0100	[thread overview]
Message-ID: <20080218135509.GC28851@elte.hu> (raw)
In-Reply-To: <20080218133127.GB12568@mit.edu>


* Theodore Tso <tytso@mit.edu> wrote:

> > So please deal with it like most other subsystem maintainers do and 
> > stop complaining about "code churn" - nobody but you changes the 
> > ext3 codebase, it's one of the codebases least affected by general 
> > kernel flux, it's an ultimate "leaf" subsystem.
> 
> Right, sorry.  I misread the filename; I thought this was against 
> fs/jbd2, instead of fs/jbd.

Btw., if people have problems with rejects from trivial patches, the 
'mpatch' tool does wonders in resolving the easy ones:

  http://oss.oracle.com/~mason/mpatch/

when you get a .rej file, first check whether mpatch can resolve it 
conflict-free:

  mpatch -d kernel/somefile.c.rej

if there are no conflicts then:

  mpatch -a kernel/somefile.c.rej

quilt refresh, review the result and it's done in the majority of cases.

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Theodore Tso <tytso@mit.edu>, Andreas Dilger <adilger@sun.com>,
	Adrian Bunk <bunk@kernel.org>,
	sct@redhat.com, akpm@linux-foundation.org,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fs/jbd/journal.c: cleanups
Date: Mon, 18 Feb 2008 14:55:09 +0100	[thread overview]
Message-ID: <20080218135509.GC28851@elte.hu> (raw)
In-Reply-To: <20080218133127.GB12568@mit.edu>


* Theodore Tso <tytso@mit.edu> wrote:

> > So please deal with it like most other subsystem maintainers do and 
> > stop complaining about "code churn" - nobody but you changes the 
> > ext3 codebase, it's one of the codebases least affected by general 
> > kernel flux, it's an ultimate "leaf" subsystem.
> 
> Right, sorry.  I misread the filename; I thought this was against 
> fs/jbd2, instead of fs/jbd.

Btw., if people have problems with rejects from trivial patches, the 
'mpatch' tool does wonders in resolving the easy ones:

  http://oss.oracle.com/~mason/mpatch/

when you get a .rej file, first check whether mpatch can resolve it 
conflict-free:

  mpatch -d kernel/somefile.c.rej

if there are no conflicts then:

  mpatch -a kernel/somefile.c.rej

quilt refresh, review the result and it's done in the majority of cases.

	Ingo

  reply	other threads:[~2008-02-18 13:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17  8:19 [2.6 patch] fs/jbd/journal.c: cleanups Adrian Bunk
2008-02-18  7:04 ` Andreas Dilger
2008-02-18  7:12   ` Ingo Molnar
2008-02-18 11:49     ` Theodore Tso
2008-02-18 12:57       ` Ingo Molnar
2008-02-18 12:57         ` Ingo Molnar
2008-02-18 13:31         ` Theodore Tso
2008-02-18 13:55           ` Ingo Molnar [this message]
2008-02-18 13:55             ` Ingo Molnar
2008-02-18 13:12       ` Adrian Bunk
2008-02-18 13:28         ` Theodore Tso
2008-02-27 19:39           ` Adrian Bunk
2008-02-18 13:31         ` Ingo Molnar
2008-02-18 15:11           ` Theodore Tso
2008-02-18 16:22             ` Ingo Molnar
2008-02-18 16:22               ` Ingo Molnar
2008-02-27 21:20   ` [2.6 patch] unexport journal_update_superblock Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080218135509.GC28851@elte.hu \
    --to=mingo@elte.hu \
    --cc=adilger@sun.com \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger \
    --cc=sct@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.