All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <stefano.brivio@polimi.it>
To: Michael Buesch <mb@bu3sch.de>
Cc: John Linville <linville@tuxdriver.com>,
	bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43(legacy): include full timestamp in beacon frames
Date: Mon, 18 Feb 2008 20:45:45 +0100	[thread overview]
Message-ID: <20080218204545.06d1aaa7@morte> (raw)
In-Reply-To: <200802181853.56155.mb@bu3sch.de>

On Mon, 18 Feb 2008 18:53:55 +0100
Michael Buesch <mb@bu3sch.de> wrote:

> From: Johannes Berg <johannes@sipsolutions.net>
> 
> Having the full RX timestamp in beacons is necessary for IBSS
> merge to work properly so extend the 16-bit timestamp to the
> full 64 bits for beacon frames (as well as when monitor mode
> is active.)

> --- everything.orig/drivers/net/wireless/b43legacy/xmit.c	2008-02-06 17:38:25.416098905 +0100
> +++ everything/drivers/net/wireless/b43legacy/xmit.c	2008-02-18 09:04:40.471819824 +0100
> @@ -546,12 +546,16 @@ void b43legacy_rx(struct b43legacy_wldev
>  	status.antenna = !!(phystat0 & B43legacy_RX_PHYST0_ANT);
>  
>  	/*
> -	 * If monitors are present get full 64-bit timestamp. This
> -	 * code assumes we get to process the packet within 16 bits
> -	 * of timestamp, i.e. about 65 milliseconds after the PHY
> -	 * received the first symbol.
> +	 * All frames on monitor interfaces and beacons always need a full
> +	 * 64-bit timestamp. Monitor interfaces need it for diagnostic
> +	 * purposes and beacons for IBSS merging.
> +	 * This code assumes we get to process the packet within 16 bits
> +	 * of timestamp, i.e. about 65 milliseconds after the PHY received
> +	 * the first symbol.
>  	 */
> -	if (dev->wl->radiotap_enabled) {
> +	if (((fctl & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE))
> +	    == (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_BEACON)) ||
> +	    dev->wl->radiotap_enabled) {
>  		u16 low_mactime_now;
>  
>  		b43legacy_tsf_read(dev, &status.mactime);

Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>


--
Ciao
Stefano

  reply	other threads:[~2008-02-18 19:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 17:53 [PATCH] b43(legacy): include full timestamp in beacon frames Michael Buesch
2008-02-18 19:45 ` Stefano Brivio [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-02-18  8:05 Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080218204545.06d1aaa7@morte \
    --to=stefano.brivio@polimi.it \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.