All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@redhat.com>
To: Mark Lord <liml@rtr.ca>
Cc: Albert Lee <albertcc@tw.ibm.com>,
	IDE/ATA development list <linux-ide@vger.kernel.org>,
	Jeff Garzik <jgarzik@pobox.com>, Alan Cox <alan@redhat.com>,
	Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH] libata-scsi: automatically use DMADIR if drive/bridge requires it
Date: Mon, 18 Feb 2008 17:20:44 -0500	[thread overview]
Message-ID: <20080218222044.GA20041@devserv.devel.redhat.com> (raw)
In-Reply-To: <47B9F05A.1060207@rtr.ca>

On Mon, Feb 18, 2008 at 03:53:46PM -0500, Mark Lord wrote:
> +		/* some SATA bridges need us to indicate data xfer direction 
> */
> +		if (atapi_dmadir || (dev->id[62] & 0x8000))

The rest of the code uses ata_ inlines/defines in ata.h for things like this
and religiously checks validity bits and ATA versions.


  reply	other threads:[~2008-02-18 22:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 19:02 atapi_dmadir: why do we not (also) auto-detect it from IDENTIFY PACKET ?? Mark Lord
2008-02-18 20:53 ` [PATCH] libata-scsi: automatically use DMADIR if drive/bridge requires it Mark Lord
2008-02-18 22:20   ` Alan Cox [this message]
2008-02-19  0:41     ` Mark Lord
2008-02-20 17:18   ` Jeff Garzik
2008-02-20 18:53     ` Mark Lord
2008-02-21  4:25       ` [PATCH] libata: " Tejun Heo
2008-02-22 10:09         ` Albert Lee
2008-02-22 13:33           ` Mark Lord
2008-02-22 14:11             ` Mark Lord
2008-02-22 16:32             ` Jeff Garzik
2008-02-24  5:29         ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080218222044.GA20041@devserv.devel.redhat.com \
    --to=alan@redhat.com \
    --cc=albertcc@tw.ibm.com \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.