All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jan Evert van Grootheest <j.e.van.grootheest@caiway.nl>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH ht6560b] Force prefetch for some devices
Date: Tue, 19 Feb 2008 00:14:55 +0100	[thread overview]
Message-ID: <200802190014.55761.bzolnier@gmail.com> (raw)
In-Reply-To: <47B97EFA.2040805@caiway.nl>

On Monday 18 February 2008, Jan Evert van Grootheest wrote:
> Prefetch needs to be set for some ide devices to work when connected to
> a ht6560b interface. This was not always done properly, causing a system
> with a HD and CD on the primary interface to not work properly. Or, in
> effect, hang hard.
> 
> This patch forces prefetch on devices before checking whether it
> is necessary to change the settings in the interface
> 
> This patch should also be applied to 2.4. I don't currently have a
> 2.4 tree around.
> 
> (also change my email address)
> 
> Signed-off-by: Jan Evert van Grootheest <janevert@caiway.nl>

I applied it as it is but could I ask you to follow up on the following
(rather minor) issues:

- According to observations from your testing and comments from Sergei/Alan
  it really seems that prefetch bit has reversed meaning so the driver should
  be updated to reflect it.

- Could the old changelog be removed while we are at it?  The detailed
  changelog is kept in the kernel git tree nowadays.

Thanks,
Bart

      parent reply	other threads:[~2008-02-19  0:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 12:50 [PATCH ht6560b] Force prefetch for some devices Jan Evert van Grootheest
2008-02-18 13:58 ` Sergei Shtylyov
2008-02-18 14:36 ` Alan Cox
2008-02-18 15:21   ` Jan Evert van Grootheest
2008-02-18 15:47     ` Alan Cox
2008-06-27 19:51   ` Jan Evert van Grootheest
2008-06-27 20:04     ` Alan Cox
2008-02-18 23:14 ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802190014.55761.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=j.e.van.grootheest@caiway.nl \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.