From: Theodore Tso <tytso@mit.edu>
To: Andreas Dilger <adilger@sun.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: How were some of the lustre e2fsprogs test cases generated?
Date: Mon, 18 Feb 2008 19:36:44 -0500 [thread overview]
Message-ID: <20080219003644.GQ25098@mit.edu> (raw)
In-Reply-To: <E1JRG0g-0001lz-Ur@closure.thunk.org>
On Mon, Feb 18, 2008 at 07:06:58PM -0500, Theodore Ts'o wrote:
>
> The clusterfs e2fsprogs code doesn't notice this, because it apparently
> ignores ee_start_hi field entirely.
One minor correction --- the clusterfs e2fsprogs extents code checks
to see if the ee_leaf_hi field is non-zero, and complains if so.
However, it ignores the ee_start_hi field for interior (non-leaf)
nodes in the extent tree, and a number of tests do have non-zero
ee_start_hi fields which cause my version of e2fsprogs to (rightly)
complain.
If you fix this, a whole bunch of tests will fail as a result, and not
exercise the code paths that the tests were apparently trying to
exercise. Which is what is causing me a bit of worry and wonder about
how those test cases were originally generated....
Regards,
- Ted
next prev parent reply other threads:[~2008-02-19 0:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 0:06 How were some of the lustre e2fsprogs test cases generated? Theodore Ts'o
2008-02-19 0:36 ` Theodore Tso [this message]
2008-02-19 11:28 ` Andreas Dilger
2008-02-19 11:40 ` Andreas Dilger
2008-02-19 12:29 ` Theodore Tso
2008-02-19 21:13 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219003644.GQ25098@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.