From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] Update: Add driver for AD7414 i2c
Date: Tue, 19 Feb 2008 19:07:19 +0000 [thread overview]
Message-ID: <20080219200719.0ebc7daa@hyperion.delvare> (raw)
In-Reply-To: <A42C17A8FF150C4DB98BFD6497D1D00008096EC6@ussvlexmbpf1.spansion.com>
On Tue, 19 Feb 2008 13:45:11 -0500, Sean MacLennan wrote:
> Jean Delvare wrote:
> >
> >> + /* Register values */
> >> + u16 temp_input;
> >> + u8 temp_max;
> >> + u8 temp_min;
> >>
> >
> > Temperature values can be negative, so these should be s16 and s8
> > respectively.
> >
> >
> I think these are fine as is. They are the raw values back from the chip
> and are always passed through AD7414_TEMP_FROM_REG.
temp_input is passed through AD7414_TEMP_FROM_REG(); temp_max and
temp_min aren't. So, the driver would fail to report negative limits
properly.
> Good catch on the simple_strtoul. I only tested positive values since
> the taco will only be dealing in positive values.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2008-02-19 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 7:53 [lm-sensors] [PATCH] Update: Add driver for AD7414 i2c Edelhaeuser, Frank
2008-02-19 11:35 ` Jean Delvare
2008-02-19 11:44 ` Edelhaeuser, Frank
2008-02-19 18:45 ` Sean MacLennan
2008-02-19 19:07 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219200719.0ebc7daa@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.