From: Yinghai Lu <Yinghai.Lu@Sun.COM>
To: Greg KH <greg@kroah.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] x86_64: fix dma_alloc_pages v2
Date: Wed, 20 Feb 2008 02:07:18 -0800 [thread overview]
Message-ID: <200802200207.18403.yinghai.lu@sun.com> (raw)
In-Reply-To: <200802200036.54406.yinghai.lu@sun.com>
please use this one instead.
because v1 already in mm, and that doesn't depends on 1/4 here.
[PATCH 2/4] x86_64: fix dma_alloc_pages fix
this patch will use updated dev_to node, because dev_to_node already make sure
it have node online
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
diff --git a/arch/x86/kernel/pci-dma_64.c b/arch/x86/kernel/pci-dma_64.c
index 931b51a..375cb2b 100644
--- a/arch/x86/kernel/pci-dma_64.c
+++ b/arch/x86/kernel/pci-dma_64.c
@@ -53,8 +53,6 @@ dma_alloc_pages(struct device *dev, gfp_t gfp, unsigned order)
int node;
node = dev_to_node(dev);
- if (node == -1 || !node_online(node))
- node = numa_node_id();
page = alloc_pages_node(node, gfp, order);
return page ? page_address(page) : NULL;
prev parent reply other threads:[~2008-02-20 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 8:15 [PATCH 0/4] make dev_to_node return online node or -1 Yinghai Lu
2008-02-20 8:32 ` [PATCH 1/4] make dev_to_node return online node Yinghai Lu
2008-02-20 20:41 ` Yinghai Lu
2008-02-20 8:34 ` [PATCH 3/4] ide: use dev_to_node instead of pcibus_to_node Yinghai Lu
2008-02-20 8:36 ` [PATCH 4/4] driver: use dev_to_node in pci_call_probe Yinghai Lu
2008-02-20 8:36 ` [PATCH 2/4] x86_64: fix dma_alloc_pages v2 Yinghai Lu
2008-02-20 10:07 ` Yinghai Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802200207.18403.yinghai.lu@sun.com \
--to=yinghai.lu@sun.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.