From: Ingo Molnar <mingo@elte.hu>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
lguest@ozlabs.org
Subject: Re: [PATCH] Fix building lguest as module.
Date: Wed, 20 Feb 2008 10:33:08 +0100 [thread overview]
Message-ID: <20080220093308.GA3881@elte.hu> (raw)
In-Reply-To: <20080219233520.GB6887@bakeyournoodle.com>
* Tony Breeds <tony@bakeyournoodle.com> wrote:
> > the right one is below. There's no 'LGUEST_MODULE' anymore -
> > 'LGUEST_GUEST' is what should be used.
>
> Hmm okay I'm confused now. LGUEST_GUEST is only set when you have
> guest support enabled, but if you're only building the host module[1]
> then that wont work.
i have no strong idea either - but no more lguest build failures anymore
in my test setup since i applied your patch with my small tweak. Rusty
has pushed his ... lightly tested git tree upstream and went on a
vacation. I'm strongly considering this new merge technique for the next
merge window myself! ;-)
Ingo
next prev parent reply other threads:[~2008-02-20 9:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 12:45 [build bug] lguest build failure: drivers/lguest/x86/switcher_32.S:(.text+0x3815f8): undefined reference to `LGUEST_PAGES_regs_trapnum' Ingo Molnar
2008-02-01 17:05 ` Ingo Molnar
2008-02-02 12:25 ` Rusty Russell
2008-02-03 20:11 ` Rusty Russell
2008-02-17 13:51 ` Thomas Gleixner
2008-02-17 14:07 ` Sergio Luis
2008-02-17 20:11 ` Christian Kujau
2008-02-18 1:04 ` Sergio Luis
2008-02-18 1:31 ` Sergio Luis
2008-02-18 22:14 ` Christian Kujau
2008-02-18 22:19 ` Sergio Luis
2008-02-19 21:20 ` Christian Kujau
2008-02-19 3:44 ` [PATCH] Fix building lguest as module Tony Breeds
2008-02-19 7:32 ` Ingo Molnar
2008-02-19 13:54 ` Ingo Molnar
2008-02-19 23:35 ` Tony Breeds
2008-02-20 9:33 ` Ingo Molnar [this message]
2008-02-20 10:01 ` Ingo Molnar
2008-02-22 5:58 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220093308.GA3881@elte.hu \
--to=mingo@elte.hu \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tony@bakeyournoodle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.