Re: [Patch 1/1] spi: Fix pxa2xx_spi.c chip select sequence error

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Sunday 17 February 2008, Ned Forrester wrote:
> +
> +               /* FIXME, need to handle cs polarity,
> +                * this driver uses struct pxa2xx_spi_chip.cs_control to
> +                * specify a CS handling function, and it ignores most
> +                * struct spi_device.mode[s], including SPI_CS_HIGH */
> +               drv_data->cs_control(PXA2XX_CS_ASSERT);
> +
> +               /* after chip select, release the data by enabling service
> +                * requests and interrupts, without changing any mode bits */
> +               write_SSCR1(cr1, reg);

This code is duplicated below ...

>         } else {
>                 if (drv_data->ssp_type != PXA25x_SSP)
>                         write_SSTO(chip->timeout, reg);

... right here:

> +
> +               /* FIXME, need to handle cs polarity,
> +                * this driver uses struct pxa2xx_spi_chip.cs_control to
> +                * specify a CS handling function, and it ignores most
> +                * struct spi_device.mode[s], including SPI_CS_HIGH */
> +               drv_data->cs_control(PXA2XX_CS_ASSERT);
> +
> +               /* after chip select, release the data by enabling service
> +                * requests and interrupts, without changing any mode bits */
>                 write_SSCR1(cr1, reg);

So it properly belongs on the other side of this bracket:

>         }

If you fix that, I'll forward this for a 2.6.25 merge.

- Dave


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/