From: "J. Bruce Fields" <bfields@fieldses.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org,
Jeff Layton <jlayton@redhat.com>
Subject: Re: [PATCH] NFS: convert nfs4 callback thread to kthread API
Date: Wed, 20 Feb 2008 10:15:32 -0500 [thread overview]
Message-ID: <20080220151532.GA30160@fieldses.org> (raw)
In-Reply-To: <1203520163.8620.14.camel@heimdal.trondhjem.org>
On Wed, Feb 20, 2008 at 10:09:23AM -0500, Trond Myklebust wrote:
>
> On Wed, 2008-02-20 at 08:55 -0500, Jeff Layton wrote:
> > There's a general push to convert kernel threads to use the (much
> > cleaner) kthread API. This patch converts the NFSv4 callback kernel
> > thread to the kthread API. In addition to being generally cleaner this
> > also removes the dependency on signals when shutting down the thread.
> >
> > Note that this patch depends on the recent patches to svc_recv() to
> > make it check kthread_should_stop() periodically. Those patches are
> > in Bruce's tree at the moment and are slated for 2.6.26 along with
> > the lockd conversion, so this conversion is probably also appropriate
> > for 2.6.26.
>
> Since this only touches the callback server, can't we just ask Bruce to
> pick up this patch and merge it together with the others?
Yep. Can I take that as an ACK from you, or do you still need to read
it over?
--b.
next prev parent reply other threads:[~2008-02-20 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 13:55 [PATCH] NFS: convert nfs4 callback thread to kthread API Jeff Layton
2008-02-20 15:09 ` Trond Myklebust
2008-02-20 15:13 ` Jeff Layton
2008-02-20 15:15 ` J. Bruce Fields [this message]
2008-02-20 15:39 ` Trond Myklebust
2008-02-22 4:58 ` J. Bruce Fields
2008-02-22 11:18 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220151532.GA30160@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.