From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id E27D7DDF84 for ; Thu, 21 Feb 2008 03:21:47 +1100 (EST) Date: Wed, 20 Feb 2008 08:16:08 -0800 From: Greg KH To: Peter Korsgaard Subject: Re: [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver Message-ID: <20080220161608.GE2658@kroah.com> References: <20080219150916.263032000@sunsite.dk> <20080219151149.684610000@sunsite.dk> <20080219235554.GA13304@kroah.com> <87bq6cf1cb.fsf@macbook.be.48ers.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <87bq6cf1cb.fsf@macbook.be.48ers.dk> Cc: linuxppc-dev@ozlabs.org, dbrownell@users.sourceforge.net, stern@rowland.harvard.edu, linux-usb@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Feb 20, 2008 at 10:01:40AM +0100, Peter Korsgaard wrote: > >>>>> "Greg" == Greg KH writes: > > Greg> On Tue, Feb 19, 2008 at 04:09:19PM +0100, Peter Korsgaard wrote: > >> This patch adds HCD support for the Cypress c67x00 family of devices. > >> > >> Signed-off-by: Peter Korsgaard > > Greg> And it doesn't build: > > Greg> CC [M] drivers/usb/c67x00/c67x00-hcd.o > Greg> distcc[2413] ERROR: compile /home/gregkh/.ccache/c67x00-hcd.tmp.mini.2409.i on localhost failed > Greg> drivers/usb/c67x00/c67x00-hcd.c:345: error: redefinition of 'c67x00_hcd_probe' > Greg> drivers/usb/c67x00/c67x00-hcd.h:119: error: previous definition of 'c67x00_hcd_probe' was here > Greg> drivers/usb/c67x00/c67x00-hcd.c:402: error: redefinition of 'c67x00_hcd_remove' > Greg> drivers/usb/c67x00/c67x00-hcd.h:126: error: previous definition of 'c67x00_hcd_remove' was here > Greg> make[2]: *** [drivers/usb/c67x00/c67x00-hcd.o] Error 1 > Greg> make[1]: *** [drivers/usb/c67x00] Error 2 > Greg> make: *** [_module_drivers/usb] Error 2 > > Huh, that doesn't make any sense to me. The dumy definitions of > c67x00_hcd_{probe,remove} are protected by an ifndef > CONFIG_USB_C67X00_HCD, and c67x00-hcd.c which contains the real > definitions only gets compiled if CONFIG_USB_C67X00_HCD is > enabled. Could you perhaps provide some more details? I don't know, I selected the config option, and yet, it built as if it wasn't set. > Anyway, the conditional hcd stuff isn't really needed at this point in > the patch series, so I have moved it into patch 4 in the v8 series > I'll post in a minute. That's good. > Greg> This is _after_ removing the obviously incorrect usb_disabled() > Greg> function that you included in your .h file. > > That was again for conditional hcd/udc support. I have now moved the > check into _hcd_probe() instead. > > Greg> I'm going to hold off applying any of these for now, as it > Greg> doesn't look like something is configured properly here. > > Could you give the v8 series a try please? Can you move the files under the hcd/ subdir, run it through checkpatch.pl and fix up the __FUNCTION__ warnings, and then I'll be willing to test it again :) thanks, greg k-h