From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JRwd7-00081P-2r for mharc-grub-devel@gnu.org; Wed, 20 Feb 2008 16:37:29 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JRwd4-00080B-Dj for grub-devel@gnu.org; Wed, 20 Feb 2008 16:37:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JRwd3-0007yp-1t for grub-devel@gnu.org; Wed, 20 Feb 2008 16:37:25 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JRwd2-0007yj-UV for grub-devel@gnu.org; Wed, 20 Feb 2008 16:37:24 -0500 Received: from ns39764.ovh.net ([91.121.25.85] helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JRwd2-0002j7-Jk for grub-devel@gnu.org; Wed, 20 Feb 2008 16:37:24 -0500 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id E672E3D92A for ; Wed, 20 Feb 2008 22:45:21 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Wed, 20 Feb 2008 22:37:23 +0100 User-Agent: KMail/1.9.4 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802202237.23419.okuji@enbug.org> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Journal support for ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2008 21:37:26 -0000 On Monday 18 February 2008 00:25, Bean wrote: > Some adjustment in this patch: as the get_block function is only used > when journal type is GRUB_FSHELP_JOURNAL_TYPE_FILE, i move it to > grub_fshelp_journal instead of using it as a parameter for > grub_fshelp_map_block. also add changelog for reiserfs.c. Thanks for your effort. However, I don't like one part. It is about types. Although I understand why you did this way, it is not a good thing that you use "int" for block addressing. This is a fundamental issue in fshelp. Because of this, filesystem support is not 64-bit safe. I don't urge you to fix everything, but please don't increase the mess. Okuji