From: Yinghai Lu <Yinghai.Lu@Sun.COM>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box
Date: Thu, 21 Feb 2008 02:58:44 -0800 [thread overview]
Message-ID: <200802210258.45011.yinghai.lu@sun.com> (raw)
quad core 8 socket system will have apic id lifting.the apic id range could
be [4, 0x23]. or [8, 0x27]. apic_is_clustered_box will think that need to three clusters
and that is large than 2. So it is treated as clustered_box.
and will get
Marking TSC unstable due to TSCs unsynchronized
even the CPUs have X86_FEATURE_CONSTANT_TSC set.
this patch offset back the apic before get apic clusterid.
or use dmi to get apic_is_clustered?
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
index 9b2be3d..5bdf1bc 100644
--- a/arch/x86/kernel/apic_64.c
+++ b/arch/x86/kernel/apic_64.c
@@ -1223,8 +1223,11 @@ __cpuinit int apic_is_clustered_box(void)
else
break;
- if (id != BAD_APICID)
+ if (id != BAD_APICID) {
+ if (id >= boot_cpu_id)
+ id -= boot_cpu_id;
__set_bit(APIC_CLUSTERID(id), clustermap);
+ }
}
/* Problem: Partially populated chassis may not have CPUs in some of
next reply other threads:[~2008-02-21 10:50 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 10:58 Yinghai Lu [this message]
2008-02-22 12:25 ` [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box Andi Kleen
2008-02-22 19:02 ` Yinghai Lu
2008-02-22 19:00 ` Andi Kleen
2008-02-22 19:04 ` Yinghai Lu
2008-02-22 19:07 ` Andi Kleen
2008-02-22 19:07 ` Yinghai Lu
2008-02-22 19:10 ` Andi Kleen
2008-02-23 8:55 ` Yinghai Lu
2008-02-24 5:48 ` [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box v2 Yinghai Lu
2008-02-24 7:50 ` Ingo Molnar
2008-02-24 12:29 ` Andi Kleen
2008-02-24 23:00 ` Yinghai Lu
2008-02-25 1:52 ` Yinghai Lu
2008-02-25 2:32 ` Yinghai Lu
2008-02-25 5:36 ` [PATCH] x86_64: for apic_is_clustered_box for vsmp v2 Yinghai Lu
2008-02-25 6:43 ` [PATCH] x86: vSMP selection in config Yinghai Lu
2008-02-26 19:40 ` Kconfig configuration restore bug [Was: x86: vSMP selection in config] Sam Ravnborg
2008-02-27 2:59 ` Roman Zippel
2008-02-29 4:09 ` [PATCH 1/3] fix recursive dependencies Roman Zippel
2008-02-29 5:05 ` Yinghai Lu
2008-02-29 13:22 ` Roman Zippel
2008-02-29 17:40 ` Sam Ravnborg
2008-02-29 20:05 ` Ingo Molnar
2008-02-29 20:04 ` Ingo Molnar
2008-02-29 4:10 ` [PATCH 2/3] fix choice dependency check Roman Zippel
2008-04-28 21:08 ` Sam Ravnborg
2008-02-29 4:11 ` [PATCH 3/3] add named choice group Roman Zippel
2008-02-26 20:05 ` [PATCH] x86: vSMP selection in config Sam Ravnborg
2008-02-26 21:03 ` Yinghai Lu
2008-02-25 5:39 ` [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box v2 Yinghai Lu
2008-02-25 19:08 ` Ravikiran Thirumalai
2008-02-25 22:05 ` Yinghai Lu
2008-02-26 3:39 ` Ravikiran Thirumalai
2008-02-26 3:46 ` Andi Kleen
2008-02-26 4:05 ` Ravikiran Thirumalai
2008-02-26 5:27 ` Yinghai Lu
2008-02-26 18:42 ` Ravikiran Thirumalai
2008-02-26 19:00 ` Yinghai Lu
2008-02-26 20:32 ` Ravikiran Thirumalai
2008-02-26 21:09 ` Yinghai Lu
2008-02-26 21:10 ` Yinghai Lu
2008-02-26 21:24 ` Ravikiran Thirumalai
2008-02-26 23:16 ` Yinghai Lu
2008-02-26 23:31 ` Ravikiran Thirumalai
2008-02-26 23:41 ` Yinghai Lu
2008-02-22 19:08 ` [PATCH] x86_64: make amd quad core 8 socket system not be clustered_box Yinghai Lu
2008-02-22 18:59 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802210258.45011.yinghai.lu@sun.com \
--to=yinghai.lu@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.